From d58db0865a5b7c74f6aced543250591da9fc12cc Mon Sep 17 00:00:00 2001
From: Puru <devpuruvj@gmail.com>
Date: Fri, 1 Dec 2023 03:25:59 +0530
Subject: [PATCH 1/4] Push

---
 .../site-kit/src/lib/components/Banner.svelte | 84 ++++++++++++-------
 1 file changed, 55 insertions(+), 29 deletions(-)

diff --git a/packages/site-kit/src/lib/components/Banner.svelte b/packages/site-kit/src/lib/components/Banner.svelte
index 50d2303..ff871c7 100644
--- a/packages/site-kit/src/lib/components/Banner.svelte
+++ b/packages/site-kit/src/lib/components/Banner.svelte
@@ -1,10 +1,3 @@
-<script context="module">
-	const banner_preferences = persisted(
-		'svelte:banner-preferences',
-		/** @type {Record<string, boolean>} */ ({})
-	);
-</script>
-
 <script>
 	import { browser } from '$app/environment';
 	import { onMount } from 'svelte';
@@ -21,11 +14,39 @@
 	 */
 	export let id;
 
+	/**
+	 * Link to the event. It must be an absolute path (https://svelte.dev/blog/runes instead of /blog/runes)
+	 * @type {string}
+	 */
+	export let href;
+
+	/**
+	 * When to start showing the banner
+	 * @type {Date}
+	 */
+	export let start;
+
+	/**
+	 * When to stop showing the banner. Banner never goes away if this value is not provided
+	 * @type {Date}
+	 */
+	export let end = new Date(2123, 12, 1);
+
+	const banner_preferences = persisted(
+		'svelte:banner-preferences',
+		/** @type {Record<string, boolean>} */ ({})
+	);
+
 	let height = 0;
+
+	const time = new Date();
+
+	$: show = $banner_preferences[id] && time > start && time < end;
+
 	$: if (browser) {
 		document.documentElement.style.setProperty(
 			'--sk-banner-bottom-height',
-			($banner_preferences[id] ? height : 0) + 'px'
+			(show ? height : 0) + 'px'
 		);
 	}
 
@@ -34,42 +55,47 @@
 	});
 </script>
 
-{#if $banner_preferences[id]}
-	<div class="banner-bottom" bind:clientHeight={height}>
-		<div class="main-area">
+<div class="banner-bottom" bind:clientHeight={height} class:show>
+	<div class="main-area">
+		<a {href}>
 			<slot />
+		</a>
 
-			{#if arrow}
-				<Icon name="arrow-right" size="1.2em" />
-			{/if}
-		</div>
-
-		<button class="close-button" on:click={() => ($banner_preferences[id] = false)}>
-			<Icon name="close" />
-		</button>
+		{#if arrow}
+			<Icon name="arrow-right" size="1.2em" />
+		{/if}
 	</div>
-{/if}
+
+	<button class="close-button" on:click={() => ($banner_preferences[id] = false)}>
+		<Icon name="close" />
+	</button>
+</div>
 
 <style>
 	.banner-bottom {
-		position: relative;
+		position: fixed;
+		bottom: 0;
+		left: 0;
+		right: 0;
+		z-index: 80;
 
 		display: flex;
 		justify-content: center;
 		align-items: center;
 
 		overflow-y: auto;
-	}
-
-	.banner-bottom {
-		position: absolute;
-		bottom: 0;
-		left: 0;
-		right: 0;
-		z-index: 80;
 
 		width: 100%;
 		height: max-content;
+
+		transition: opacity 0.2s 0.2s var(--quint-out);
+		opacity: 0;
+		pointer-events: none;
+	}
+
+	.show {
+		pointer-events: all;
+		opacity: 1;
 	}
 
 	.banner-bottom {

From 316619bfa1b58a74754f8b937438707ca9464221 Mon Sep 17 00:00:00 2001
From: Puru <devpuruvj@gmail.com>
Date: Fri, 1 Dec 2023 03:26:31 +0530
Subject: [PATCH 2/4] Add changeset

---
 .changeset/clean-wombats-work.md | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 .changeset/clean-wombats-work.md

diff --git a/.changeset/clean-wombats-work.md b/.changeset/clean-wombats-work.md
new file mode 100644
index 0000000..7aea1f4
--- /dev/null
+++ b/.changeset/clean-wombats-work.md
@@ -0,0 +1,5 @@
+---
+'@sveltejs/site-kit': patch
+---
+
+feat: Time-bound banner

From 9dd8d2820354398a04893e7cb65fd42afedc538c Mon Sep 17 00:00:00 2001
From: Puru <devpuruvj@gmail.com>
Date: Sat, 2 Dec 2023 00:50:13 +0530
Subject: [PATCH 3/4] Banners

---
 .../site-kit/src/lib/components/Banner.svelte |  9 +++++
 .../src/lib/components/Banners.svelte         | 33 +++++++++++++++++++
 packages/site-kit/src/lib/components/index.js |  2 +-
 3 files changed, 43 insertions(+), 1 deletion(-)
 create mode 100644 packages/site-kit/src/lib/components/Banners.svelte

diff --git a/packages/site-kit/src/lib/components/Banner.svelte b/packages/site-kit/src/lib/components/Banner.svelte
index ff871c7..340c763 100644
--- a/packages/site-kit/src/lib/components/Banner.svelte
+++ b/packages/site-kit/src/lib/components/Banner.svelte
@@ -1,3 +1,12 @@
+<script context="module">
+	/**
+	 * @typedef {'svelte.dev' | 'kit.svelte.dev' | 'learn.svelte.dev'} BannerScope
+	 * @typedef {(import('svelte').ComponentProps<import('./Banner.svelte').default> & {
+	 * content: string; scope?: BannerScope[]
+	 * })[]} BannerData
+	 */
+</script>
+
 <script>
 	import { browser } from '$app/environment';
 	import { onMount } from 'svelte';
diff --git a/packages/site-kit/src/lib/components/Banners.svelte b/packages/site-kit/src/lib/components/Banners.svelte
new file mode 100644
index 0000000..6a6a118
--- /dev/null
+++ b/packages/site-kit/src/lib/components/Banners.svelte
@@ -0,0 +1,33 @@
+<script context="module">
+	/**
+	 * Only to be used on non svelte.dev sites. Shouldn't be used inside svelte.dev codebase itself
+	 * @param {import('./Banner.svelte').BannerScope} scope
+	 * @param {import('@sveltejs/kit').RequestEvent['fetch']} fetch
+	 */
+	export async function fetchBanner(scope = 'svelte.dev', fetch) {
+		if (scope === 'svelte.dev') return fetch('/banner.json').then((r) => r.json());
+
+		const req = await fetch('https://svelte.dev/banner.json');
+		if (!req.ok) {
+			console.warn('There was an error fetching the banner data. Check svelte.dev/banner.json');
+			return [];
+		}
+
+		return /** @type {import('./Banner.svelte').BannerData} */ (await req.json()).filter(
+			(banner) => !banner.scope || banner.scope?.includes(scope)
+		);
+	}
+</script>
+
+<script>
+	import Banner from './Banner.svelte';
+
+	/** @type {import('./Banner.svelte').BannerData} */
+	export let data;
+</script>
+
+{#each data as { content, href, id, start, arrow, end }}
+	<Banner {id} start={new Date(start)} end={end ? new Date(end) : undefined} {arrow} {href}>
+		{@html content}
+	</Banner>
+{/each}
diff --git a/packages/site-kit/src/lib/components/index.js b/packages/site-kit/src/lib/components/index.js
index a962aad..24a9904 100644
--- a/packages/site-kit/src/lib/components/index.js
+++ b/packages/site-kit/src/lib/components/index.js
@@ -1,6 +1,6 @@
+export { default as Banners, fetchBanner } from './Banners.svelte';
 export { default as Icon } from './Icon.svelte';
 export { default as Icons } from './Icons.svelte';
 export { default as Section } from './Section.svelte';
 export { default as Shell } from './Shell.svelte';
 export { default as ThemeToggle } from './ThemeToggle.svelte';
-export { default as Banner } from './Banner.svelte';

From 5c83ab9600ca252001411581b8359b23eca49cfa Mon Sep 17 00:00:00 2001
From: Puru <devpuruvj@gmail.com>
Date: Sat, 2 Dec 2023 22:05:18 +0530
Subject: [PATCH 4/4] Explicitly type

---
 packages/site-kit/src/lib/components/Banners.svelte | 1 +
 1 file changed, 1 insertion(+)

diff --git a/packages/site-kit/src/lib/components/Banners.svelte b/packages/site-kit/src/lib/components/Banners.svelte
index 6a6a118..b34f3fc 100644
--- a/packages/site-kit/src/lib/components/Banners.svelte
+++ b/packages/site-kit/src/lib/components/Banners.svelte
@@ -3,6 +3,7 @@
 	 * Only to be used on non svelte.dev sites. Shouldn't be used inside svelte.dev codebase itself
 	 * @param {import('./Banner.svelte').BannerScope} scope
 	 * @param {import('@sveltejs/kit').RequestEvent['fetch']} fetch
+	 * @returns {Promise<import('./Banner.svelte').BannerData>}
 	 */
 	export async function fetchBanner(scope = 'svelte.dev', fetch) {
 		if (scope === 'svelte.dev') return fetch('/banner.json').then((r) => r.json());