Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing fails on script tag when id is empty #219

Closed
4 tasks done
shirotech opened this issue Sep 15, 2022 · 2 comments · Fixed by #220
Closed
4 tasks done

Parsing fails on script tag when id is empty #219

shirotech opened this issue Sep 15, 2022 · 2 comments · Fixed by #220
Labels
bug Something isn't working

Comments

@shirotech
Copy link

shirotech commented Sep 15, 2022 •
edited
Loading

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I'm using eslint-plugin-svelte. (*.svelte file linting does not work with the parser alone. You should also use eslint-plugin-svelte with it.)
  • I'm sure the problem is a parser problem. (If you are not sure, search for the issue in eslint-plugin-svelte repo and open the issue in eslint-plugin-svelte repo if there is no solution.
  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.

What version of ESLint are you using?

8.23.1

What version of eslint-plugin-svelte and svelte-eslint-parser are you using?

What did you do?

Configuration 
<!-- Paste your configuration here -->

<head>
  <slot/>
  <link href="/style.css" rel="stylesheet">
  <script id="">const foo = 'Anything goes here';</script>
</head>

What did you expect to happen?

No error

What actually happened?

Parsing error: </script> attempted to close an element that was not open

Link to Minimal Reproducible Example

Not required

Additional comments

No response
@shirotech shirotech changed the title Parsing fails on non-root script elements Parsing fails on non-root script elements with non self closing tag Sep 15, 2022
@shirotech shirotech changed the title Parsing fails on non-root script elements with non self closing tag Parsing fails on non self closing tag Sep 15, 2022
@shirotech shirotech changed the title Parsing fails on non self closing tag Parsing fails on script tag when id is empty Sep 15, 2022
@ota-meshi ota-meshi added the needs repro Need a repository that can reproduce the problem label Sep 15, 2022
@ota-meshi
Copy link
Member

ota-meshi commented Sep 15, 2022 •
edited
Loading

I cannot reproduce your problem. Please always share the repo to reproduce.

@shirotech
Copy link
Author

shirotech commented Sep 15, 2022 •
edited
Loading

@ota-meshi sorry, okay here it is:

https://ota-meshi.github.io/svelte-eslint-parser/playground/#eJxNj7EOwyAMRH/F8pKpYW9JpP4HS0ScQEohwlZVVPXfi0KHTD4/n+7kD9o0E15RO5rm0UQAzSGJ+kub/S4gZafBoNBb1Da9poYNgp8rrpOzrUJxetKlHfuNDY5ata2lBR8f4DIth1dKoN5ytUGmUNFB2BHV5HP9aFNkgSUlGKC7xyLOxxXWRAyOMnW3U41WxyP4/QGp6EqZ

If you try removing the id="" then it works.

@ota-meshi ota-meshi mentioned this issue Sep 16, 2022
Merged
@JounQin JounQin added bug Something isn't working and removed needs repro Need a repository that can reproduce the problem labels Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: parsing error when <script> has attribute with empty value sveltejs/svelte-eslint-parser
3 participants
@shirotech @JounQin @ota-meshi