Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) fallback to empty string if there are no attributes #397

Merged
merged 1 commit into from
Sep 5, 2021

Conversation

dummdidumm
Copy link
Member

Fixes #396

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests with npm test or yarn test

Copy link
Member

@kaisermann kaisermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@kaisermann kaisermann merged commit b25838f into sveltejs:main Sep 5, 2021
@frederikhors
Copy link
Contributor

There are many lint suggestions in this PR from Github.

@frederikhors
Copy link
Contributor

image

@frederikhors
Copy link
Contributor

image

@kaisermann
Copy link
Member

@frederikhors Despite being in favour of both these rules (I put them in the project), the first is more of a nuisance and the second is just wrong for these respective cases. It's safe to ignore them 😁

@dummdidumm dummdidumm deleted the fix-nullpointer branch September 5, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

From 4.9.0: Cannot read property 'split' of undefined
3 participants