Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) handle $store imported in module script #404

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

dummdidumm
Copy link
Member

Fixes #401

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests with npm test or yarn test

@kaisermann kaisermann merged commit 162faa4 into sveltejs:main Sep 9, 2021
@dummdidumm dummdidumm deleted the fix-ts-modulestore branch September 9, 2021 10:25
@kaisermann
Copy link
Member

🙏 Thanks as always 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4.9 broke accessing stores with $ prefix when imported in module context
2 participants