Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust store regex #441

Merged
merged 3 commits into from
Dec 16, 2021
Merged

fix: adjust store regex #441

merged 3 commits into from
Dec 16, 2021

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Dec 10, 2021

Don't match in the case of $° or $§ or $\, these are not store variables

Fixes #433

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests with npm test or yarn test

Don't match in the case of $° or $§ or $\, these are not store variables

Fixes sveltejs#433
@kaisermann kaisermann changed the title (fix) adjust store regex fix: adjust store regex Dec 13, 2021
@dummdidumm
Copy link
Member Author

dummdidumm commented Dec 16, 2021

Added a test

@dummdidumm dummdidumm merged commit 85a86c8 into sveltejs:main Dec 16, 2021
@dummdidumm dummdidumm deleted the patch-1 branch December 16, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"error TS1127: Invalid character" from text in comments, error message fails to point at location
2 participants