-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace sorcery #637
Comments
This would fix #636 as well |
We're fixing up |
This can be ripped out entirely as part of a major if we do one soon - this code is from a time when typescript didn't have good support for separating between value and type imports |
Removed as part of #640 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
sorcery
is outdated and unmaintained. It prints deprecation warnings for users. It also adds a dependency that isn't used elsewhere in the Svelte ecosystemDescribe the solution you'd like
Replace
sorcery
with@ampproject/remapping
like we do in Sveltesvelte-preprocess/src/transformers/typescript.ts
Line 263 in 276037a
https://github.com/sveltejs/svelte/blob/84ad208f2e986fa549683a12e7f999c3d31b127f/packages/svelte/package.json#L132
I wonder if we even need to combine source maps though? What is
injectVarsToCode
doing?Describe alternatives you've considered
Update
sorcery
. But even then it'd be nice to have fewer dependencies in a new SvelteKit appHow important is this feature to you?
Important at the moment because it's causing sveltejs/kit#12258
The text was updated successfully, but these errors were encountered: