Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alias listName to deconflict with shared helpers #1231

Merged
merged 1 commit into from
Mar 15, 2018
Merged

Conversation

Rich-Harris
Copy link
Member

fixes #1229, albeit perhaps slightly inelegantly. i feel like there's probably some further refactoring opportunities around context

@codecov-io
Copy link

codecov-io commented Mar 13, 2018

Codecov Report

Merging #1231 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1231      +/-   ##
==========================================
+ Coverage   91.72%   91.73%   +<.01%     
==========================================
  Files         126      126              
  Lines        4570     4571       +1     
  Branches     1493     1493              
==========================================
+ Hits         4192     4193       +1     
  Misses        157      157              
  Partials      221      221
Impacted Files Coverage Δ
src/generators/dom/Block.ts 96.85% <100%> (+0.02%) ⬆️
src/generators/nodes/EachBlock.ts 98.12% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ac7701...01f6f9f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context variable overrides shared helper when hydratable: true
2 participants