Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.15.0 throws incorrect error when using component-defined store #1828

Closed
tivac opened this issue Oct 30, 2018 · 2 comments
Closed

2.15.0 throws incorrect error when using component-defined store #1828

tivac opened this issue Oct 30, 2018 · 2 comments

Comments

@tivac
Copy link
Contributor

tivac commented Oct 30, 2018

Before 2.15.0 this worked fine.

https://svelte.technology/repl?version=2.14.3&gist=eb560c5e77f6768961e81c8b377c81ff

In 2.15.0 it throws an error because the check doesn't work for the store property that a component can set itself.

https://svelte.technology/repl?version=2.15.0&gist=eb560c5e77f6768961e81c8b377c81ff

I'm certain this is fallout from #1811 but haven't dug in yet to see why it's broken.
@tivac
Copy link
Contributor Author

tivac commented Oct 30, 2018

It's because the checks aren't looking at templateProperties.store, just options.store. I'm working on a PR but svelte's tests hate my windows machine.

@tivac tivac mentioned this issue Oct 30, 2018
Merged
@Conduitry
Copy link
Member

npm finally cooperated, and published fix in 2.15.1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tivac @Conduitry