Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add an example of modifying complex store data #3053

Open
pngwn opened this issue Jun 19, 2019 · 10 comments
Open

Docs: Add an example of modifying complex store data #3053

pngwn opened this issue Jun 19, 2019 · 10 comments
Labels
documentation popular more than 20 upthumbs

Comments

@pngwn
Copy link
Member

pngwn commented Jun 19, 2019

People seems to be asking at regular intervals about how to update complex data in a store and, while it is relatively straight forward, we could add an example somewhere. Maybe in the tutorial.

@MVSICA-FICTA
Copy link

MVSICA-FICTA commented Jun 20, 2019

This would be helpful. Plus, also add something about the RxJS support that was introduced in #2549

Another important aspect is how stores can be used with local or remote databases. For instance, if using IndexedDB are stores still necessary? Stores seem to have a lot of uses including being a wrapper for a XState Interpreter instance.

Having a store exhibit page that brings together store usages along with mini tutorials sounds good to me.

@fiskgrodan
Copy link
Contributor

I think it's a good idea.

Maybe an example with a custom store with immerjs produce drafts?

And maybe an example of subscribing and saving changes to localStorage and reading from localStorage on startup?

@Conduitry Conduitry added the docs label Jun 21, 2019
@nick-walt
Copy link

nick-walt commented Jun 30, 2019

Would be great. As well as a discussion about data and state in Svelte and how Stores are best used to model a Svelte app. Happy to help with editing.

@conick
Copy link

conick commented Jul 2, 2019

Just an example with local storage in my usage. May be useful to someone:

function lsWritable(key, type) {
    let initialValue = localStorage.getItem(key);
    if (type == 'numeric') {
        initialValue = Number(initialValue);
    }
    const { subscribe, set } = writable(initialValue);

    return {
        subscribe,
        set: (value) => {
            localStorage.setItem(key, value);
            return set(value);
        },
    };
}

And then:

export const userName = lsWritable('userName');
export const userAge = lsWritable('userAge', 'numeric');

@nodefish
Copy link

nodefish commented Sep 3, 2019

I can't seem to find any info/examples anywhere on the Internet about the best practice for doing something equivalent to hierarchical/namespaced state management with Svelte v3 stores. It seems n>0 depth is not supported but I cannot find an alternative, other than just having a multitude of top-level stores for every value, which is rather spaghetti-ish.

In particular, I found it surprising that updating a property on an object in a store triggers the reactivity cycle for the whole store. This seems like a pretty big footgun and I feel like the documentation doesn't do enough to warn about this.

I would appreciate it if anyone could post a tiny paragraph on how to handle hierarchical state. Are we supposed to have dozens/hundreds of stores, even for related values?

@nick-walt
Copy link

nick-walt commented Sep 3, 2019

Redux is a simple set of APIs and its architecture is very clearly articulated. Yet the Docs are extensive!

Redux dedicates an entire site to documentation and teaching.

Additionally, there are numerous articles by the authors about the design of Redux, the best ways to use it, alternative ways to use it and, importantly, how not to use it.

I think that the motivation of wanting to be a very flexible library is could result in a fantastic ecosystem.

But holding back on expressing the motivations and intent behind Svelte's design choices and providing clear guidance on the best patterns to use (and what not to use) may inhibit adoption.

I think @nodefish hits it on the head. Responses and guidance to his and others' questions could be kept informal and less prescriptive (via official blog articles) while evolving the discussion and documentation.

If Svelte had a good home for maintaining persistent, searchable and easily discoverable discussions the progression of body-of-knowledge could be:
Chat > Forum > Blog > Docs.

@kuhlaid
Copy link

kuhlaid commented Apr 27, 2020

In response to @MVSICA-FICTA regarding indexedDb I have found that for indexedDb it is probably a good idea to save your db connection object to a Svelte store like:

export const objAppDbConn = writable(); // example within the store.js

... then in your App.svelte use something like the following to save the connection:

var openRequest = indexedDB.open(strAppDbName, 1);

openRequest.onupgradeneeded = function(e) {
  $objAppDbConn = e.target.result;   // set Svelte store to db connection
...

...otherwise if you switch between components you will lose the connection to indexedDb. I'm sure it probably depends on your app architecture but for me the Svelte store was crucial to maintain connection to indexedDb.

@nickolasgregory
Copy link

Though I've not yet looked in-depth; it may be worth examining https://github.com/Budibase/budibase for some ideas as there does seems to be extensive use of stores.

@derolf
Copy link

derolf commented Nov 15, 2021

@NNNN2
Copy link

NNNN2 commented Jan 20, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation popular more than 20 upthumbs
Projects
None yet
Development

No branches or pull requests