Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVGAttributes typing does not include data-* attributes #9035

Closed
paoloricciuti opened this issue Jul 24, 2023 · 0 comments · Fixed by #9036
Closed

SVGAttributes typing does not include data-* attributes #9035

paoloricciuti opened this issue Jul 24, 2023 · 0 comments · Fixed by #9036

Comments

@paoloricciuti
Copy link
Member

Describe the bug

On svg's you can still apply data-* attributes but if you try to define a component with

ComponentType<SvelteComponent<SVGAttributes<SVGSVGElement>>>;

SVGAttributes does not include data-* attributes so you get an error when you try to use the component

Reproduction

I've added the ambient.d.ts which declare every svg?component as the aforementioned type

https://www.sveltelab.dev/lvwp6fymf3vnjgs

check the errors in +page.svelte

Logs

No response

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.20.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 9.4.2 - /usr/local/bin/npm
    pnpm: 8.6.3 - /usr/local/bin/pnpm
  npmPackages:
    svelte: ^4.0.0 => 4.1.1

Severity

annoyance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants