From 2140236eb3176f5d3ee155cdf8c4f2acda0723c5 Mon Sep 17 00:00:00 2001 From: Moritz Friedrich Date: Mon, 20 Nov 2023 08:47:02 +0100 Subject: [PATCH 1/3] Lowers log level to debug This message isn't immediately actionable for developers and can reasonably be considered debugging output. Therefore, the log level has been updated to reflect this. --- packages/vite-plugin-svelte/src/handle-hot-update.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/vite-plugin-svelte/src/handle-hot-update.js b/packages/vite-plugin-svelte/src/handle-hot-update.js index 46b9cf1cc..e0faabe8c 100644 --- a/packages/vite-plugin-svelte/src/handle-hot-update.js +++ b/packages/vite-plugin-svelte/src/handle-hot-update.js @@ -104,7 +104,7 @@ function jsChanged(prev, next, filename) { } const isLooseEqual = isCodeEqual(normalizeJsCode(prevJs), normalizeJsCode(nextJs)); if (!isStrictEqual && isLooseEqual) { - log.warn( + log.debug( `ignoring compiler output js change for ${filename} as it is equal to previous output after normalization` ); } From 88219f99a4caf6904d0283e1783ff7494e2d4d35 Mon Sep 17 00:00:00 2001 From: Moritz Friedrich Date: Mon, 20 Nov 2023 16:17:01 +0100 Subject: [PATCH 2/3] Adds a debug section This commit adds a debug section for "hmr" to the line, as suggested by @dominikg. Co-authored-by: Dominik G. --- packages/vite-plugin-svelte/src/handle-hot-update.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/vite-plugin-svelte/src/handle-hot-update.js b/packages/vite-plugin-svelte/src/handle-hot-update.js index e0faabe8c..f54fc4321 100644 --- a/packages/vite-plugin-svelte/src/handle-hot-update.js +++ b/packages/vite-plugin-svelte/src/handle-hot-update.js @@ -105,7 +105,9 @@ function jsChanged(prev, next, filename) { const isLooseEqual = isCodeEqual(normalizeJsCode(prevJs), normalizeJsCode(nextJs)); if (!isStrictEqual && isLooseEqual) { log.debug( - `ignoring compiler output js change for ${filename} as it is equal to previous output after normalization` + `ignoring compiler output js change for ${filename} as it is equal to previous output after normalization`, + undefined, + 'hmr' ); } return !isLooseEqual; From 4c501ffe26039d9cd426b9e2c9e61ebe715feef6 Mon Sep 17 00:00:00 2001 From: Moritz Friedrich Date: Mon, 20 Nov 2023 16:39:35 +0100 Subject: [PATCH 3/3] Adds changeset --- .changeset/wet-drinks-call.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/wet-drinks-call.md diff --git a/.changeset/wet-drinks-call.md b/.changeset/wet-drinks-call.md new file mode 100644 index 000000000..8b88506d7 --- /dev/null +++ b/.changeset/wet-drinks-call.md @@ -0,0 +1,5 @@ +--- +'@sveltejs/vite-plugin-svelte': patch +--- + +Update log level for HMR updates where the output is functionally equivalent to the previous version to "debug"