Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release a forked gem #1

Open
andytinycat opened this issue Jan 16, 2014 · 14 comments
Open

Release a forked gem #1

andytinycat opened this issue Jan 16, 2014 · 14 comments

Comments

@andytinycat
Copy link
Collaborator

You don't have a license in this repository. Would you mind if I released a new gem based on your code and the enhancements contained in this fork? I would credit you and BIAINC and would be happy to give you contributor access to the repository.

I ask because I've got a use-case for resque-heartbeat, plus the enhancements, and I'd like to have it as a public gem rather than installed from GitHub.

@andytinycat
Copy link
Collaborator Author

@jonp I see you've contributed to the fork in BIAINC; would you mind me releasing a gem based on your code? Again, there's no license, and I don't want to assume one. Again, I would credit you.

(I would have left this as an issue on the fork, but issues are turned off for that repository.)

@svenfuchs
Copy link
Owner

@andytinycat I don't use this code anymore, feel free to use it in any way you want. I'll be happy to slap an MIT license on this repo if that helps, care to send a PR in that case?

@jonp
Copy link
Collaborator

jonp commented Jan 16, 2014

I'd be happy to send a PR. I didn't do that before because I changed it to track individual worker processes instead of the whole machine. Knowing that, @svenfuchs, do you still want it?

@andytinycat
Copy link
Collaborator Author

I've created a new gem in this repository. If you're happy, I'm going to release this once I've tested it.

@jonp
Copy link
Collaborator

jonp commented Jan 17, 2014

Instead of putting out competing forks, let's improve this one if @svenfuchs is interested. I've submitted a PR

@svenfuchs
Copy link
Owner

@andytinycat @jonp i've just added you guys as collaborators.

unfortunately i don't really have time to take care of this codebase, but it seems you're having some great ideas. so feel free to take over.

if you'd like to keep using this repository feel free to do so. if you'd like to continue in your forks or other repos, that's perfectly fine, too. i don't feel attached to this code at all :)

@jonp
Copy link
Collaborator

jonp commented Jan 17, 2014

Ok, thanks @svenfuchs !
Do you have a problem with my merging my PR, adding the MIT license and then publishing a new version of the gem?

Edit: If not, then I'll need publish permissions in rubygems.

@svenfuchs
Copy link
Owner

@jonp no, as i said, no problems at all.

you guys feel free to merge, add, change whatever you like :)

@andytinycat
Copy link
Collaborator Author

If you could give us both publish permissions in RubyGems that would be excellent. If you do that, I will happily pull my gem down*. If you've not done it before, it's this command: http://guides.rubygems.org/command-reference/#gem_owner

You need our RubyGems email addresses; mine is [email protected].

  • well, basically turn it into a zero code gem that requires resque-heartbeat (like bundle -> bundler)

@svenfuchs
Copy link
Owner

@andytinycat added

$ gem owner --add [email protected] resque-heartbeat
Owner added successfully.
Owners for gem: resque-heartbeat
- [email protected]
- [email protected]

Will be happy to add @jonp, too. Although you can now also do that, right?

@hlascelles
Copy link

What is the current status of this gem? I think it looks like what we need. We have a build up of non-existent workers reported in resque-web as AWS Autoscale terminates boxes.

Can v0.1.0 be cut as a gem?

Thanks!

@jonp
Copy link
Collaborator

jonp commented Feb 10, 2014

@andytinycat or @svenfuchs , could you add me to the gem maintainer list? I'll take care of releasing this.

@hlascelles
Copy link

@jonp are you going to be the maintainer going forward?

@jonp
Copy link
Collaborator

jonp commented Feb 24, 2014

@hlascelles I would be happy to. I need to get on the gem maintainer list, thought. @svenfuchs I haven't heard back from @andytinycat , so could you add me to the list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants