fix: sanitize() double encode special characters #3271
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
URL().toString()
to construct sanitised URI (including support of IP v6 URIs).Fall back to the existent functionality in cases when URL() can not parse the URI.
Motivation and Context
The problem is described in #3270 .
Existent sanitize implementation doesn't return correct result when the URI contains encoded 'special' characters such as
; / ? : @ & = + $ , #
.Closes #3270
How Has This Been Tested?
Tested with existent unit tests.
Extended test for the case with special characters and added test case for IP v6.
Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests