Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spring] Templates and generator already migrated? #254

Closed
HanMas123 opened this issue Dec 5, 2018 · 3 comments
Closed

[Spring] Templates and generator already migrated? #254

HanMas123 opened this issue Dec 5, 2018 · 3 comments
Assignees
Milestone

Comments

@HanMas123
Copy link

HanMas123 commented Dec 5, 2018

Hi,

currently we are "suffering" from this bug #103
I was wondering why this fix did not apply to our setup and did some investigations...
We are using the swagger-codegen-maven-plugin having the library option configured to spring.
The SpringCodegen class is still using Mustache as template engine.

// todo: remove this once handlebar templates for this generator are implemented
    @Override
    protected void setTemplateEngine() {
        templateEngine = new MustacheTemplateEngine(this);
    }

It looks like the templates have already been migrated. At least there are template in the handlebar folder https://github.com/swagger-api/swagger-codegen-generators/tree/master/src/main/resources/handlebars/JavaSpring

I would really like to take the fix into our spring codegen setup and I am willing to migrate/help migrating but I am not sure what is left to do to migrate spring code gen from mustache templates to handlebars.

@HugoMario HugoMario self-assigned this Dec 14, 2018
@wvitte
Copy link

wvitte commented Jan 3, 2019

I am running in this bug #103 as well . I was wondering if there's any way to choose which template engine to use through some configuration or settings?

@HugoMario
Copy link
Contributor

hello @HanMas123 @wvitte , this issue has been fixed, so going to close it but please let me know if you still get the issue and i'll help with it.

@HugoMario HugoMario added this to the v3.0.4 milestone Jan 14, 2019
@wvitte
Copy link

wvitte commented Jan 14, 2019

Thanks @HugoMario looks like it's working. Any idea when v3.0.4 would be out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants