Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current status on 508 compliance and accessibility #4935

Closed
Ryandaydev opened this issue Oct 10, 2018 · 8 comments
Closed

Current status on 508 compliance and accessibility #4935

Ryandaydev opened this issue Oct 10, 2018 · 8 comments

Comments

@Ryandaydev
Copy link

Ryandaydev commented Oct 10, 2018

I wanted to touch base and see the current status of any efforts for improving accessibility and 508 compliance for the open source swagger UI?

I found the issues below, and some have been closed, so I don't to make duplicate work if there is already an effort in place.

Here are prior gh issues on this topic (some in older versions):
#2216
#3235
#1021

For reference, I ran some automated tests on a site using the 3.18.3 distribution and found quite a few violations, which I could share offline. (I also fixed many of them but only in the swagger-ui-bundle.js, which appears to be a generated file so that probably isn't enough to send in a PR.)

@Ryandaydev Ryandaydev changed the title Current status on 508 compliance and accessibilty Current status on 508 compliance and accessibility Oct 10, 2018
@shockey
Copy link
Contributor

shockey commented Oct 11, 2018

Hi @Ryandaydev!

I don't know of anyone working on this at the moment.

If you're interested in making some PRs around this, please reach out to me - we have some UI/UX changes coming down the pipeline, so I'd like to understand what you're planning to do in order to make the components/elements of concern are still relevant.

Feel free to book an available session during my office hours.

@Ryandaydev
Copy link
Author

Nice chatting with you the other day, @shockey. I will wait to see your next release and then will plan on testing and contributing some recommended changes for 508 compliance and accessibility.

Note: if anyone other govvies are interested assisting with this effort, reach out to me directlyl

@shockey
Copy link
Contributor

shockey commented Oct 23, 2018

You as well @Ryandaydev - I'll reach out to you within a month with an update.

@Ryandaydev
Copy link
Author

@shockey I wanted to touch base to see what the current status is?

@shockey
Copy link
Contributor

shockey commented Dec 3, 2018

Hi @Ryandaydev - no updates from my end. If you're ready to move forward with your contributions, I can handle the legwork in making sure that they fit in well with anything else coming from our side 😄

@Ryandaydev
Copy link
Author

OK, so do you suggest that we go ahead and make a pull request off of the 3.18.3 branch?

@shockey
Copy link
Contributor

shockey commented Dec 3, 2018

Please open a PR against master - if there are any conflicts, I can take care of them!

@shockey
Copy link
Contributor

shockey commented Jan 15, 2019

Closing - this has been addressed out-of-band 😄

@shockey shockey closed this as completed Jan 15, 2019
@lock lock bot locked and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants