importsNotUsedAsValues is wrong

[kdy1]

@kdy1 This is not the behaviour of tsc under "importsNotUsedAsValues": "preserve". The correct behaviour is to never preserve completely unused import identifiers. The above branch should always be used.

I think ImportNotUsedAsValues should be removed since it's a misunderstanding of the equivalent tsc option.

Originally posted by @nayeemrmn in #1060 (comment)

It's a breaking change.

[nayeemrmn]

@kdy1 What if I don't remove the option, but disassociate it with any behaviour for now? The behaviour it's currently associated with should unconditionally be "remove".

[kdy1]

I think it's not correct. I think it should at least panic if an option which causes wrong behavior is provided.
Actaully decorator pass does it, because decorator metadata for current proposal is not implemented yet.

[nayeemrmn]

@kdy1 Nevermind, I can fix it to cause the correct behaviour.

[kdy1]

@nayeemrmn Sounds great!

[swc-bot]

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.