Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(es/preset-env): Update preset-env data #9573

Merged
merged 23 commits into from
Oct 8, 2024
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Sep 20, 2024

@kdy1 kdy1 added this to the Planned milestone Sep 20, 2024
@kdy1 kdy1 self-assigned this Sep 20, 2024
Copy link

changeset-bot bot commented Sep 20, 2024

🦋 Changeset detected

Latest commit: e402f9e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

socket-security bot commented Sep 20, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

["esnext.composite-symbol", SYMBOL_DEPENDENCIES]
),
fetch: define(null, PROMISE_DEPENDENCIES),
globalThis: define("global-this", ["es.global-this", "esnext.global-this"]),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codspeed-hq bot commented Sep 20, 2024

CodSpeed Performance Report

Merging #9573 will degrade performances by 7.75%

Comparing kdy1:issue-9544 (aa9e767) with main (166b858)

Summary

❌ 2 regressions
✅ 192 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kdy1:issue-9544 Change
es/full/bugs-1 519.8 µs 563.4 µs -7.75%
serialization of serde 2.8 µs 2.9 µs -3.03%

@kdy1 kdy1 marked this pull request as ready for review September 23, 2024 18:58
@kdy1 kdy1 requested review from a team as code owners September 23, 2024 18:58
kodiakhq[bot]
kodiakhq bot previously approved these changes Sep 23, 2024
kodiakhq[bot]
kodiakhq bot previously approved these changes Sep 30, 2024
@kdy1 kdy1 enabled auto-merge (squash) September 30, 2024 02:14
kodiakhq[bot]
kodiakhq bot previously approved these changes Sep 30, 2024
@@ -1,6 +1,6 @@
require("core-js/modules/es.array.at.js");
require("core-js/modules/es.regexp.exec.js");
require("core-js/modules/es.string.at-alternative.js");
require("core-js/modules/es.string.at.js");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core-js doesn't have a module with this name.

@kdy1 kdy1 disabled auto-merge September 30, 2024 04:18
@kdy1 kdy1 marked this pull request as draft October 1, 2024 02:15
@kdy1 kdy1 marked this pull request as ready for review October 8, 2024 03:10
Copy link

socket-security bot commented Oct 8, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] filesystem Transitive: environment +24 822 kB cwmma
npm/[email protected] environment, filesystem, shell, unsafe Transitive: network +136 2.55 MB evilebottnawi
npm/[email protected] environment, filesystem, network Transitive: eval, shell, unsafe +290 11.1 MB evilebottnawi
npm/[email protected] environment, filesystem, unsafe Transitive: eval, network, shell +263 13.8 MB thelarkinn

🚮 Removed packages: npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/plugin-bugfix-safari-id-destructuring-collision-in-function-expression@7.18.6, npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@bcoe/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@cspell/[email protected], npm/@istanbuljs/[email protected], npm/@istanbuljs/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jridgewell/[email protected], npm/@jridgewell/[email protected], npm/@jridgewell/[email protected], npm/@jridgewell/[email protected], npm/@jridgewell/[email protected], npm/@jridgewell/[email protected], npm/@sinclair/[email protected], npm/@sinonjs/[email protected], npm/@sinonjs/[email protected], npm/@swc/[email protected], npm/@swc/[email protected], npm/@taplo/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 8, 2024
@kdy1 kdy1 enabled auto-merge (squash) October 8, 2024 03:10
@kdy1 kdy1 disabled auto-merge October 8, 2024 04:13
@kdy1 kdy1 merged commit 9a11d34 into swc-project:main Oct 8, 2024
154 checks passed
@kdy1 kdy1 deleted the issue-9544 branch October 8, 2024 04:45
require("core-js/modules/es.object.to-string.js");
document.querySelectorAll('div').forEach(function(el) {
console.log(el);
});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kdy1 to fix #9544, it should also load web.dom-collections.for-each, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I'll reopen it.

@kdy1 kdy1 modified the milestones: Planned, v1.7.33 Oct 10, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Core-js forEach import polyfill not working, Babel with the same config works fine
2 participants