Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ast): Add archive(check_bytes) to all relevant AST types #9574

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

jerrykingxyz
Copy link
Contributor

@jerrykingxyz jerrykingxyz commented Sep 20, 2024

Description:

  1. all struct that support rkyv add archive(check_bytes)
  2. all recursive struct that support rkyv add check_bytes bound

this PR will fix the error reported in #9562

BREAKING CHANGE:
No

Related issue (if exists):

@jerrykingxyz jerrykingxyz requested review from a team as code owners September 20, 2024 06:04
Copy link

changeset-bot bot commented Sep 20, 2024

🦋 Changeset detected

Latest commit: 900ac67

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 self-assigned this Sep 20, 2024
@kdy1 kdy1 added this to the Planned milestone Sep 20, 2024
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kdy1 kdy1 changed the title fix: all struct that support rkyv add archive(check_bytes) fix(ast): Add archive(check_bytes) to all relevant AST types Sep 20, 2024
@kdy1 kdy1 merged commit 185d6f5 into swc-project:main Sep 20, 2024
24 checks passed
Copy link

codspeed-hq bot commented Sep 20, 2024

CodSpeed Performance Report

Merging #9574 will not alter performance

Comparing jerrykingxyz:rkyv (900ac67) with main (185d6f5)

Summary

✅ 178 untouched benchmarks

@kdy1 kdy1 modified the milestones: Planned, v1.7.28 Sep 24, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants