Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check broken images and mermaid graphs #201

Closed
rmarquis opened this issue Sep 3, 2024 · 2 comments · Fixed by #202
Closed

Check broken images and mermaid graphs #201

rmarquis opened this issue Sep 3, 2024 · 2 comments · Fixed by #202
Assignees
Labels
bug Something isn't working

Comments

@rmarquis
Copy link
Contributor

rmarquis commented Sep 3, 2024

It looks like the udpate to last mkdocs-material broke things:

  • inlined icons (:simple-name:)
  • mermaid graph orientation (see part 1)
  • mermaid graph label on multilines

Mermaid 11 was introduced in the last mkdocs-material update. Investigate, and if not possible to fix, revert to the previous version for the time being.

@rmarquis rmarquis added the bug Something isn't working label Sep 3, 2024
@rmarquis rmarquis self-assigned this Sep 3, 2024
@rmarquis
Copy link
Contributor Author

rmarquis commented Sep 4, 2024

See simple-icons/simple-icons#11236 for missing windows icons: Microsoft legal team requested that customized Microsoft icons be removed for legal branding issue.

They have been removed from the simple iconset, used by mkdocs-material.

Check and replace these missing icons. I think It should only be the windows icon.

@rmarquis
Copy link
Contributor Author

rmarquis commented Sep 4, 2024

As for the mermaid graph, it seems this is related to the latest update of mkdocs which now includes Mermaid 11. Changing the orientation of the messed up graphs (part 2) should be enough.

This issue is not visible in the currently deployed version, but will be once #200 is merged.
Change the orientation of the graph.

@rmarquis rmarquis linked a pull request Sep 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant