Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to tape-run v9.0.0 #2

Open
axelpale opened this issue Jan 17, 2021 · 5 comments
Open

Upgrade to tape-run v9.0.0 #2

axelpale opened this issue Jan 17, 2021 · 5 comments

Comments

@axelpale
Copy link

axelpale commented Jan 17, 2021

Thanks for the plugin. Please consider upgrading to tape-run v8.0.0 from the currently depended v3.0.0. Npm audit lists low-level vulnerabilities associated with the old tape-run, an example below. In case you are interested, we use webpack-tape-run in tapspace to run a headless test suite.

┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Low           │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ minimist                                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=0.2.1 <1.0.0 || >=1.2.3                                    │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ webpack-tape-run [dev]                                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ webpack-tape-run > tape-run > browser-run >                  │
│               │ html-inject-script > trumpet > html-tokenize > minimist      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/1179                            │
└───────────────┴──────────────────────────────────────────────────────────────┘
@syarul
Copy link
Owner

syarul commented Mar 8, 2021

I'll do the update once I'm a bit free, or you can submit a pull request

@syarul
Copy link
Owner

syarul commented Aug 17, 2021

Updated to tape-run v5 and Webpack v5.50, tape-run v8 having issue when test failed. Until then using v5

@syarul syarul closed this as completed Aug 17, 2021
@syarul syarul reopened this Aug 18, 2021
@axelpale axelpale changed the title Upgrade to tape-run v8.0.0 Upgrade to tape-run v9.0.0 Apr 1, 2022
@axelpale
Copy link
Author

axelpale commented Apr 1, 2022

Thank you @syarul for your work on keeping up with the updates. It is hard work. Currently tape-run is at 9.0.0 and depends on browser-run at 10.1.0. Most if not all of the audit issues of webpack-tape-run seem to be caused by browser-run 9 or older.

@CryptozombiesCorp
Copy link

This needs to be upgraded, cause this package can't run on AMD64 Macs right now. Cause your using such an old version of tape-run you are getting a super old version of electron that isn't supported on M1 Macs

@syarul
Copy link
Owner

syarul commented Oct 16, 2022

@CryptozombiesCorp @axelpale There's issue on electron later version that block CORS. The stream that supposedly failed is not return instead it return as Failed to execute 'send' on 'XMLHttpRequest'. I've tried few solution but so far does not work, it might take sometimes to solve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants