Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPC / -related keybindings with grep broken in develop #1987

Closed
tko opened this issue Jun 14, 2015 · 9 comments
Closed

SPC / -related keybindings with grep broken in develop #1987

tko opened this issue Jun 14, 2015 · 9 comments

Comments

@tko
Copy link
Contributor

tko commented Jun 14, 2015

SPC / just gives an error Wrong type argument: commandp, helm-project-do-grep

@justbur
Copy link
Contributor

justbur commented Jun 14, 2015

It's a bug in the smart search function at the moment. SPC psg should work. The function you want to call is helm-projectile-grep.

@tko
Copy link
Contributor Author

tko commented Jun 14, 2015

On further note SPC b /, SPC s /, and SPC f / are also giving similar errors.

(Is "s /" intentionally bound to same function as "b /"? The ag functions are different.)

@justbur
Copy link
Contributor

justbur commented Jun 14, 2015

The basic problem is that @syl20bnr recently added/changed the search functions using functions defined in helm-ag for ag, pt and ack. The grep functions for helm are defined elsewhere and don't map one-to-one with the helm-ag ones. Your smart search is defaulting to grep and looking for the non-existent functions. We just need to add appropriate ones for grep.

@tko tko changed the title SPC / broken in develop SPC / -related keybindings with grep broken in develop Jun 14, 2015
@tko
Copy link
Contributor Author

tko commented Jun 14, 2015

Right, I figured as much, but I don't know enough elisp to quite figure out what was going on. Your patch is a good pointer.

@syl20bnr
Copy link
Owner

It requires the last version of helm for grep. For the other tools it should be ok.

@syl20bnr
Copy link
Owner

Ah yes grep is broken for project scope, it needs a wrapper helm-project-do-grep.
I don't really checked grep because for project ag is way superior and easy to install, on windows pt is really easy to install as well (made in go).

@syl20bnr
Copy link
Owner

Should be fixed in develop, thanks @justbur !

@tko
Copy link
Contributor Author

tko commented Jun 15, 2015

FWIW for grep the keybindings are working.

In the meantime I installed 'ag' to see what the fuzz is all about and now it seems all the "b /", "s /", and "f /" bindings are failing with Wrong type argument: commandp, helm-buffers-do-ag and similar... (I'm not actually using any of those, just thought to try them out.)

@syl20bnr
Copy link
Owner

Should be better in develop now.
Don't forget to check the new bindings: https://github.com/syl20bnr/spacemacs/blob/develop/doc/DOCUMENTATION.org#with-an-external-tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants