-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPC / -related keybindings with grep broken in develop #1987
Comments
It's a bug in the smart search function at the moment. |
On further note SPC b /, SPC s /, and SPC f / are also giving similar errors. (Is "s /" intentionally bound to same function as "b /"? The ag functions are different.) |
The basic problem is that @syl20bnr recently added/changed the search functions using functions defined in helm-ag for ag, pt and ack. The grep functions for helm are defined elsewhere and don't map one-to-one with the helm-ag ones. Your smart search is defaulting to grep and looking for the non-existent functions. We just need to add appropriate ones for grep. |
Right, I figured as much, but I don't know enough elisp to quite figure out what was going on. Your patch is a good pointer. |
It requires the last version of helm for grep. For the other tools it should be ok. |
Ah yes grep is broken for project scope, it needs a wrapper |
Should be fixed in develop, thanks @justbur ! |
FWIW for grep the keybindings are working. In the meantime I installed 'ag' to see what the fuzz is all about and now it seems all the "b /", "s /", and "f /" bindings are failing with |
Should be better in develop now. |
SPC / just gives an error
Wrong type argument: commandp, helm-project-do-grep
The text was updated successfully, but these errors were encountered: