Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution times in 2.3.2RC1 #1684

Closed
designermonkey opened this issue Mar 11, 2013 · 16 comments
Closed

Execution times in 2.3.2RC1 #1684

designermonkey opened this issue Mar 11, 2013 · 16 comments

Comments

@designermonkey
Copy link
Member

I'm seeing a massive difference in execution times since installing 2.3.2RC1 with regards to using the Debug Devkit. When I use the devkit, it takes about three times longer to generate anything than it did when using 2.3.1

Loading the page in the frontend is still the same. I do believe that this is a core problem and not related to the extension, as I didn't update the extension straight away.

I can give more details if required, and @brendo if you need a login again to see it, let me know.

@brendo
Copy link
Member

brendo commented Mar 11, 2013

Login would useful. Nothing has changed in the core regarding devkits, although Debug Devkit was updated to a new version (integration into master). Odd you are seeing worse times, mine actually feels much quicker and the browser doesn't lock up as it used to.

My guess is that it's something to do with the Bitter library being updated, possibly a more intensive regular expression, the only other changes were adding languages.

@designermonkey
Copy link
Member Author

There is a lot, and I mean a lot of data being loaded on the page. When it was loaded with the previous devkit, it was quicker though.

It's not impacting performance on the site without the devkit, still generates really fast, it's just when generating the xml view of the devkit.

Details sent via iChat ;)

@designermonkey
Copy link
Member Author

Just for other readers of this thread, @brendo had a look at the site in question and agreed that the execution time was indeed quite long.

I will be looking into reverting the devkit to an older version and seeing what the time difference is on the same page, when I get a second free.

@brendo brendo closed this as completed Mar 26, 2013
@michael-e
Copy link
Member

Has this been solved?

@designermonkey
Copy link
Member Author

Unfortunately, I havent been able to re-address this with the data set it was appearing on. It was a very large data set, and could have been that which caused the overhead.

I'm afraid I won't be able to look into this again for a while as the install is under lock and key for reasons I'm not able to explain.

As no-one else has come across this issue, it's best to close it until I can address it again.

@creativedutchmen
Copy link
Member

Ive had the exact same issue: pages load in the blink of an eye, but the debug page takes ages.

It could be that the browser has problems displaying the huge sets, I'll do some timing tomorrow.

On Tue, Mar 26, 2013 at 9:40 PM, John Porter [email protected]
wrote:

Unfortunately, I havent been able to re-address this with the data set it was appearing on. It was a very large data set, and could have been that which caused the overhead.
I'm afraid I won't be able to look into this again for a while as the install is under lock and key for reasons I'm not able to explain.

As no-one else has come across this issue, it's best to close it until I can address it again.

Reply to this email directly or view it on GitHub:
#1684 (comment)

@designermonkey
Copy link
Member Author

At least it's not just me then.

There's been a regex change in bitter which @brendo suggested may have something to do with it.

@michael-e
Copy link
Member

That issue doesn't sound good to me. Even on Symphony 2.2.5 I have to use ?debug=raw all the time, because ?debug doesn't work with larger XML (at least not in an acceptable time frame).

@michael-e
Copy link
Member

That has to be discussed, of course. Here is my vote: I never use the XPath search.

@michael-e
Copy link
Member

Baaah. What a shame. I have approx. 10k lines of XML.

@michael-e
Copy link
Member

Just tried with CodeMirror. Took a very long time, but it didn't crash the browser.

Here's a sample. I only removed the cookie-related params.

@michael-e
Copy link
Member

Please tell me when you have downloaded the file. It shouldn't be online for too long.

@michael-e
Copy link
Member

Thanks!

@michael-e
Copy link
Member

You may wonder if that XML makes sense. Well, it does. Large parts of it are saved as complete XML strings to the database by importer routines. When the page is built, these XML strings are added "at once", just like formatted textarea content. So the whole process is still rather fast. Page creation takes around 0.5 seconds overall on a non-exotic virtual server. (XSLT is still very fast!)

@ghost ghost reopened this Apr 10, 2013
@nilshoerrmann
Copy link
Contributor

We bundle CodeMirror with Factory, so maybe the styles used for the project could be reused: https://github.com/symphonycms/factory/blob/master/css/factory.css#L623-L659

It's a light theme though, so it would be more suitable for the usage in the backend not the devkit.

@brendo
Copy link
Member

brendo commented Apr 16, 2013

As this is a Debug Devkit change, I've opened the issue there

@brendo brendo closed this as completed Apr 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants