Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<!-- END RELEASE NOTES --> not handled correctly when it isn't on its own line #52

Open
asmeurer opened this issue Mar 1, 2019 · 1 comment
Open

<!-- END RELEASE NOTES --> not handled correctly when it isn't on its own line #52

asmeurer opened this issue Mar 1, 2019 · 1 comment

Comments

@asmeurer
Copy link
Member

asmeurer commented Mar 1, 2019

See sympy/sympy#15917. The <!-- END RELEASE NOTES --> got added to the release notes.
@asmeurer
Copy link
Member Author

asmeurer commented Mar 1, 2019

Detecting things that are hidden in the rendered HTML generically seems hard. We would need to parse the Markdown, but neither of the Python markdown libraries seem particularly fun to use.

Maybe we could do a poor-man's parsing (we only need to guard against ` and ``` code blocks). We would also probably want to whitelist real tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asmeurer