Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same comment for release notes and file added checks #90

Open
sylee957 opened this issue Jul 5, 2020 · 4 comments
Open

Use the same comment for release notes and file added checks #90

sylee957 opened this issue Jul 5, 2020 · 4 comments

Comments

@sylee957
Copy link
Member

sylee957 commented Jul 5, 2020

sympy/sympy#19708

@asmeurer
Copy link
Member

asmeurer commented Jul 6, 2020

I don't see it. I see one comment for the release notes and one for the added files. Was there a comment that was deleted?

@sylee957
Copy link
Member Author

sylee957 commented Jul 6, 2020

Okay, I didn’t know that another comment is added for file deleting.

@sylee957 sylee957 closed this as completed Jul 6, 2020
@asmeurer
Copy link
Member

asmeurer commented Jul 6, 2020

We could merge them into one comment. I just did a separate comment to make it clear that they are separate checks, but maybe it would be cleaner as a single comment.

@asmeurer asmeurer changed the title Sympy bot posts duplicate comment Use the same comment for release notes and file added checks Jul 6, 2020
@asmeurer
Copy link
Member

asmeurer commented Jul 6, 2020

That would also be better for seeing the history, since currently it deletes the file added comment if the commits are rebased and the added files are removed. But if it were in the same comment, you could still see it in the comment edit history.

@asmeurer asmeurer reopened this Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants