leveldb: fix table file leaks when manifest is rotated (#409)

syndtr · Jul 21, 2022 · 126854a · 126854a
1 parent 64ee559
commit 126854a
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/leveldb/session.go b/leveldb/session.go
@@ -223,9 +223,12 @@ func (s *session) commit(r *sessionRecord, trivial bool) (err error) {
 		}
 	}()
 
-	if s.manifest == nil || s.manifest.Size() >= s.o.GetMaxManifestFileSize() {
+	if s.manifest == nil {
 		// manifest journal writer not yet created, create one
 		err = s.newManifest(r, nv)
+	} else if s.manifest.Size() >= s.o.GetMaxManifestFileSize() {
+		// pass nil sessionRecord to avoid over-reference table file
+		err = s.newManifest(nil, nv)
 	} else {
 		err = s.flushManifest(r)
 	}