Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: No constraints or retry attempt when failing to obtain price data for conversion resulting in error when interacting with Blocktank #1833

Closed
catch-21 opened this issue May 15, 2024 · 3 comments · Fixed by #1838
Assignees
Labels
bug Something isn't working triage This issue needs to be looked over by the team

Comments

@catch-21
Copy link
Contributor

catch-21 commented May 15, 2024

Describe the bug

If Bitkit starts without being able to retrieve price data (has happened to me a few timesunder normal conditions) and it doesn't have past data to use then it displays a dash for the dollar value (see first screenshot). From then on it does not attempt to fix this state even if network conditions are good. As a result, there is no price data for creating a LN channel (see second screenshot).

It would be good to prevent access to any action that requires live price data on the client side.
It would be good to retry obtaining price data if it has been unsuccessful.

Reproduce

  1. With no network (aeroplane mode)
  2. With a new instance of Bitkit
  3. Create a new wallet
  4. Allow network access (disable aeroplane mode)
  5. Tap the 0 bitcoin balance to display dollar
  6. Observe a dash for dollar price instead of 0 (this is probably an ok representation but there are no attempts to update live price data, even with a manual pull-down to refresh)
  7. Tap Receive at the bottom
  8. Tap Receive on Spending Balance
  9. Input valid amount and Continue
  10. Observe 'Undefined' fiat amount in description
  11. Tap Continue
  12. Observe CJIT Error and no progression to create invoice

Screenshots / Recording

Dollar value displays with a dash when there is no price conversion info

Attempting to create CJIT channel displays 'undefined' and produces error

Operating system

Android 13 TKQ1.220829.002

Bitkit version

d710a89

Log output

No response

@catch-21 catch-21 added bug Something isn't working triage This issue needs to be looked over by the team labels May 15, 2024
@catch-21 catch-21 changed the title [Bug]: No recovery when failing to obtain price data for conversion resulting in error when interacting with Blocktank [Bug]: No retry attempt when failing to obtain price data for conversion resulting in error when interacting with Blocktank May 15, 2024
@catch-21 catch-21 changed the title [Bug]: No retry attempt when failing to obtain price data for conversion resulting in error when interacting with Blocktank [Bug]: No constraints or retry attempt when failing to obtain price data for conversion resulting in error when interacting with Blocktank May 15, 2024
@limpbrains limpbrains self-assigned this May 16, 2024
@catch-21
Copy link
Contributor Author

Tested on v118
This is much improved. I see that the price data is updated automatically and correctly.
However, I did notice that the $0 service provider fee and CJIT Error: init_channel_manager can be provoked when attempting to receive spending balance with no network.
@limpbrains would you suggest addressing here or in new issue?

@limpbrains
Copy link
Collaborator

definetly a new issue

@catch-21
Copy link
Contributor Author

Raised #1898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage This issue needs to be looked over by the team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants