Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If getTransactionData fails syncLdk is still completed as a success #13

Open
Jasonvdb opened this issue Jun 29, 2022 · 0 comments
Open
Labels
question Further information is requested

Comments

@Jasonvdb
Copy link
Collaborator

Noticed then when elecrtum was returning an error (missing tx probably due to electrum node being out of sync) the channels just never become usable. If any of the promises fetching tx data return an error should we should flag the whole sync as a fail? In some cases the tx might not have propagated yet I guess.

Also should we force getTransactionData to differentiate between an error and a missing tx?

'Unable to retrieve transaction data from the getTransactionData method.',

Electrum response:
{"id":0.21657926857935722,"error":false,"method":"getTransactions","data":[{"jsonrpc":"2.0","error":{"code":2,"message":"daemon error: DaemonError({'code': -5, 'message': 'No such mempool or blockchain transaction. Use gettransaction for wallet transactions.'})"},"id":8,"param":"2b9eb794af7793290e999d9c66d2f48a391e8575adfd7a8114f5a2fe159eda01","data":{"tx_hash":"2b9eb794af7793290e999d9c66d2f48a391e8575adfd7a8114f5a2fe159eda01"}}],"network":"bitcoinRegtest"}

@Jasonvdb Jasonvdb added the question Further information is requested label Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant