From e04685826d61d3617d073a172a185103fc6a9f25 Mon Sep 17 00:00:00 2001 From: bogdansurdu Date: Thu, 16 Sep 2021 04:01:53 +0300 Subject: [PATCH 1/4] add general PR template --- .../pull_request_template.md | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE/pull_request_template.md diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md new file mode 100644 index 00000000..6b440b6e --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -0,0 +1,25 @@ +--- +name: Pull Request +about: Make a pull request detailing a developed feature or change +title: '' +labels: status:triage + +--- + +## Pull request checklist + +Please check if your PR fulfills the following requirements: +- [ ] There is not an existing pull request for the same update or change +- [ ] Tests covering the changes or additions have been added +- [ ] All of the tests in the CI pipeline are passing +- [ ] Docs have been updated or modified to reflect the changes or additions +- [ ] The pull request follows the guidelines in our Contributing document + +**Is your feature request related to an existing issue? Please reference.** + + +**Please describe your proposed changes** + + +**Additional information and context** + From b01783f7aa40aa827b4bbd500dbbc3b53485f348 Mon Sep 17 00:00:00 2001 From: bogdansurdu Date: Thu, 16 Sep 2021 04:02:17 +0300 Subject: [PATCH 2/4] add bug fix PR template --- .../PULL_REQUEST_TEMPLATE/bug_fix_template.md | 30 +++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE/bug_fix_template.md diff --git a/.github/PULL_REQUEST_TEMPLATE/bug_fix_template.md b/.github/PULL_REQUEST_TEMPLATE/bug_fix_template.md new file mode 100644 index 00000000..552f0da1 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/bug_fix_template.md @@ -0,0 +1,30 @@ +--- +name: Bug Fix Pull Request +about: Make a pull request detailing a solution to a bug +title: '' +labels: status:triage + +--- + +## Pull request checklist + +Please check if your PR fulfills the following requirements: +- [ ] There is not an existing pull request solving the same bug +- [ ] A bug report issue detailing the problem has been created +- [ ] The steps that reproduced the bug no longer lead to the same behaviour +- [ ] All of the tests in the CI pipeline are passing +- [ ] Docs have been updated or modified to reflect any changes +- [ ] The bug fix follows the guidelines in our Contributing document + +**Please link the related bug report issue reference** + + + +**Please describe your proposed solution** + + +**How has this been tested?** + + +**Additional information and context** + From 84fdf008824ad9054cc0865e1a080fee63ba15c2 Mon Sep 17 00:00:00 2001 From: Simon Swan Date: Wed, 27 Apr 2022 14:06:54 +0100 Subject: [PATCH 3/4] Update and rename .github/PULL_REQUEST_TEMPLATE/pull_request_template.md to .github/pull_request_template.md --- .../pull_request_template.md | 25 ------------------- .github/pull_request_template.md | 14 +++++++++++ 2 files changed, 14 insertions(+), 25 deletions(-) delete mode 100644 .github/PULL_REQUEST_TEMPLATE/pull_request_template.md create mode 100644 .github/pull_request_template.md diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md deleted file mode 100644 index 6b440b6e..00000000 --- a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md +++ /dev/null @@ -1,25 +0,0 @@ ---- -name: Pull Request -about: Make a pull request detailing a developed feature or change -title: '' -labels: status:triage - ---- - -## Pull request checklist - -Please check if your PR fulfills the following requirements: -- [ ] There is not an existing pull request for the same update or change -- [ ] Tests covering the changes or additions have been added -- [ ] All of the tests in the CI pipeline are passing -- [ ] Docs have been updated or modified to reflect the changes or additions -- [ ] The pull request follows the guidelines in our Contributing document - -**Is your feature request related to an existing issue? Please reference.** - - -**Please describe your proposed changes** - - -**Additional information and context** - diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 00000000..6144eb93 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,14 @@ +## Description + + + +## Pull request checklist + +Please check if your PR fulfills the following requirements. ~Cross out~ items if they aren't applicable: +- [ ] There is not an existing pull request for the same update or change +- [ ] Tests covering the changes or additions have been added +- [ ] Docs have been updated or modified to reflect the changes or additions +- [ ] The pull request follows the guidelines in our Contributing document + +## Related issues: +- # From 8b92b5501aabab88c92ce08ca376743bf05671e3 Mon Sep 17 00:00:00 2001 From: Simon Swan Date: Wed, 27 Apr 2022 14:08:03 +0100 Subject: [PATCH 4/4] Delete bug_fix_template.md Optional PR templates are only supported through query parameters at the moment. Sticking to just one PR template for now. --- .../PULL_REQUEST_TEMPLATE/bug_fix_template.md | 30 ------------------- 1 file changed, 30 deletions(-) delete mode 100644 .github/PULL_REQUEST_TEMPLATE/bug_fix_template.md diff --git a/.github/PULL_REQUEST_TEMPLATE/bug_fix_template.md b/.github/PULL_REQUEST_TEMPLATE/bug_fix_template.md deleted file mode 100644 index 552f0da1..00000000 --- a/.github/PULL_REQUEST_TEMPLATE/bug_fix_template.md +++ /dev/null @@ -1,30 +0,0 @@ ---- -name: Bug Fix Pull Request -about: Make a pull request detailing a solution to a bug -title: '' -labels: status:triage - ---- - -## Pull request checklist - -Please check if your PR fulfills the following requirements: -- [ ] There is not an existing pull request solving the same bug -- [ ] A bug report issue detailing the problem has been created -- [ ] The steps that reproduced the bug no longer lead to the same behaviour -- [ ] All of the tests in the CI pipeline are passing -- [ ] Docs have been updated or modified to reflect any changes -- [ ] The bug fix follows the guidelines in our Contributing document - -**Please link the related bug report issue reference** - - - -**Please describe your proposed solution** - - -**How has this been tested?** - - -**Additional information and context** -