fixes #497 Keep image data URI if no image data is loaded #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptc-tgamper
commented
Jul 31, 2024
| return false; | ||
| // If image has a uri, and it is not a data uri, use it as filename | ||
| if (!image.uri.empty()) { | ||
| if (!IsDataURI(image.uri)) { |
There was a problem hiding this comment.
Now we can end up here with a data URI, so protect against that case
ptc-tgamper
commented
Jul 31, 2024
| // If the image is encoded as data URI, and the actual image data was | ||
| // not extracted, then we keep the original data URI that holds all | ||
| // the data. | ||
| if (IsDataURI(uri) && ok && image->image.empty()) { |
There was a problem hiding this comment.
Keep the uri only if the data has not been loaded. Otherwise we have it in memory twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not discard image data uri if uri still needed