Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow compile if git version is not defined #2768

Closed
alpes214 opened this issue May 11, 2020 · 5 comments
Closed

Do not allow compile if git version is not defined #2768

alpes214 opened this issue May 11, 2020 · 5 comments

Comments

@alpes214
Copy link
Contributor

The proxysql can be built not from git repo, but from archive. In this case GIT_VERSION variable in Makefile is not initialized. This is a request for change Makefile so it will generate error if GIT_VERSION is not set and stop build process.

@renecannao
Copy link
Contributor

Fixed

@renecannao
Copy link
Contributor

Reopening, this was not applied to 2.1.0

@renecannao renecannao reopened this May 17, 2020
@JavierJF
Copy link
Collaborator

It was already applied to v2.1.0

@otooi
Copy link

otooi commented Dec 1, 2021

@renecannao @JavierJF It happens again in v2.3.2.

make[1]: Leaving directory '/root/proxysql-2.3.2/lib'
cd src && OPTZ="-O2 -ggdb" CC=cc CXX=g++ make
make[1]: Entering directory '/root/proxysql-2.3.2/src'
fatal: No names found, cannot describe anything.
Makefile:4: *** GIT_VERSION is not set.  Stop.
make[1]: Leaving directory '/root/proxysql-2.3.2/src'
Makefile:96: recipe for target 'build_src' failed
make: *** [build_src] Error 2

@renecannao
Copy link
Contributor

Hi @otooi .
I suspect you misread the issue.
It is a behavior by design, and this issue tracks the implementation of this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants