Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocean Tile Missing | TileMaker Intermittent Bug #495

Closed
koufopoulosf opened this issue Jun 7, 2023 · 4 comments
Closed

Ocean Tile Missing | TileMaker Intermittent Bug #495

koufopoulosf opened this issue Jun 7, 2023 · 4 comments

Comments

@koufopoulosf
Copy link

Hello,

First of all I would like to thank you very much for this wonderful tool. I love it! However ...

I am making this issue as I have noticed that tilemaker faces some issues with ocean tiles. In particular, I have created the map of Greece, using the official Geofabrik file (greece-latest.osm.pbf).

Moreover, I proceeded to create an MBTiles file, using the Shortbread Schema. For that process, I used both of these 2 repositories:

  1. geofabrik/shortbread-tilemaker
  2. versatiles-org/shortbread-tilemaker

In the first case, the map had no ocean at all:

image

While in the second case, the map had the ocean layer, however with a partially missing tile:

image

At this point, let me mention that even if I were to rebuild the vector tiles, the result would remain the same.

I have proceeded to make an issue on both repositories:

On Geofabrik: https://github.com/geofabrik/shortbread-tilemaker/issues/18
On VersaTiles: versatiles-org/shortbread-tilemaker#3

From VersaTiles, @yetzt noticed more issues related to my issue here that are coming from the tilemaker repository:
systemed/tilemaker/issues/417
systemed/tilemaker/issues/401

@systemed Are there any plans on fixing this major issue?

This issue prevents people from using this tool and I would very much appreciate if you could take action on this matter and solve it.

Thank you very much for your valuable time and I look forward to your response.

Best Regards,

koufopoulosf

@koufopoulosf koufopoulosf changed the title Ocean Tile Missing | Deal Breaker - Major TileMaker Issue Ocean Tile Missing | TileMaker Intermittent Bug Jun 7, 2023
@systemed
Copy link
Owner

systemed commented Jun 7, 2023

Could you confirm the exact steps to reproduce - e.g.

  1. download greece-latest.osm.pbf from https://download.friendlyosmcompany.com/greece/extracts/
  2. use fresh install of tilemaker (built from source) on Ubuntu 22.04
  3. download coastline files from https://osmdata.somewhereorother.com/ and place in the coastline/ directory
  4. run tilemaker with the following command line: tilemaker --input greece-latest.osm.pbf --output greece.mbtiles --process etc. etc.
  5. view created mbtiles with (whatever you're using)
  6. etc.

major issue
This issue prevents people from using this tool

Please don't put judgemental comments/assumptions in github issues, just keep it factual and dispassionate. And please don't bomb my private email with followups, it won't get your issue fixed any faster.

@yetzt
Copy link

yetzt commented Jun 7, 2023

@koufopoulosf
Copy link
Author

I tried to reproduce the issue on a new linux server, however the issue just disappeared. On the previous linux server I had installed different versions of libraries, so I suppose something made a conflict when building tilemaker fom source? I really do not know.

Furthermore, I am sorry if you took my comment personally, I did not mean to hurt your feelings.

Last, I just sent you a single polite email in case you could had a look, I don't understand how the word "bomb" came from.

In any way, I would like to thank you very much for your valuable reply and I would recommend as well for people facing this issue to try a fresh installation on a different server in case of a library/package conflict creating this issue.

@systemed
Copy link
Owner

systemed commented Jun 7, 2023

That's great, I'm glad it's working. :)

It could well be an issue with an old version of Boost.Geometry, or potentially if you had an older version of tilemaker kicking around, it may have been a bug that's already been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants