Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polymorphic types not resolved correctly in classes that implement Comparator. #219

Open
t-rasmud opened this issue Jan 8, 2021 · 0 comments

Comments

@t-rasmud
Copy link
Owner

t-rasmud commented Jan 8, 2021

Consider the following test case:

import java.util.Comparator;
import org.checkerframework.checker.determinism.qual.PolyDet;

public class ComparatorIssue {
    public static void test(
            @PolyDet Class<?> @PolyDet [] result, @PolyDet MyComparator classComparator) {
        sortProxy(result, classComparator);
    }

    private static class MyComparator implements Comparator<Class<?>> {

        @Override
        public int compare(Class<?> c1, Class<?> c2) {
            return c1.getName().compareTo(c2.getName());
        }
    }

    public static <T> void sortProxy(T @PolyDet [] a, @PolyDet("use") Comparator<? super T> c) {}
}

Running the command javac -processor determinism checker/tests/determinism/ComparatorIssue.java -AusePolyDefault
results in the following unexpected error:

checker/tests/determinism/ComparatorIssue.java:8: error: [argument.type.incompatible] incompatible argument for parameter c of sortProxy.
        sortProxy(result, classComparator);
                          ^
  found   : @PolyDet MyComparator
  required: @PolyDet Comparator<? extends @NonDet Object super @PolyDet Class<? extends @NonDet Object>>
checker/tests/determinism/ComparatorIssue.java:8: error: [argument.type.incompatible] incompatible argument for parameter c of sortProxy.
        sortProxy(result, classComparator);
                          ^
  found   : @PolyDet MyComparator
  required: @PolyDet Comparator<? extends @NonDet Object super @PolyDet Class<? extends @NonDet Object>>
2 errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant