wash: Adding a descriptive array of the enabled WPS configuration methods to json output

[He1my]

What are your thoughts about adding an easier method to output the WPS configuration methods in json,
for example
"wps_config_methods": "2084", "wps_config_methods_str": ["Label", "Push Button", "Virtual Display"],

according to Wireshark the bit values for the WPS configuration methods are

.... .... .... ...1	USB
.... .... .... ..1.	Ethernet
.... .... .... .1..	Label
.... .... .... 1...	Display
.... .... ...1 ....	External NFC
.... .... ..1. ....	Internal NFC
.... .... .1.. ....	NFC Interface
.... .... 1... ....	Push Button
.... ...1 .... ....	Keybad
.... ..1. .... ....	Virtual Push Button
.... .1.. .... ....	Physical Push Button
..1. .... .... ....	Virtual Display
.1.. .... .... ....	Physical Display

[rofl0r]

i've stated on several occasions that the existing json output will not be modified (apart from eventually adding new field), so users of it have the guarantee that their scripts (consuming the json) will keep working.

it's trivial to add code in your script that parses the raw config methods.

we could provide a tiny filter tool (in tools/) which takes the default wash output and modifies into the form suggested by you: ./wash -j -s -n 100 | ../tools/pimp_json.py | yourfinalscript.py

[He1my]

what is suggested here is adding a new field "wps_config_methods_str", I am well aware that there should not be any modification to existing fields

[rofl0r]

PR welcome

[DJDan]

This already exists in wash 1.6.5-git-1-g140507a
wash -j json output has wps_config_methods .

[He1my]

This already exists in wash 1.6.5-git-1-g140507a
wash -j json output has wps_config_methods .

yes "wps_config_methods" is there, but that is not what this is about, it is about adding another field "wps_config_methods_str" that shows the enabled wps config method names instead of just the hex value to make things easier to understand