Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Https for remote RPC #95

Open
cinderblock opened this issue Jun 22, 2016 · 0 comments
Open

Https for remote RPC #95

cinderblock opened this issue Jun 22, 2016 · 0 comments

Comments

@cinderblock
Copy link

The guvnor config file says that the remote rpc connections are made with https: https://github.com/tableflip/guvnor/blob/v3.5.17/guvnor#L52

This however does not seem to the be case. I tried to setup nginx as a proxy to my guvnor instance so that a remote guvnor-web could connect to it remotely and have nginx handle the https. Unfortunately, the connections always drop immediately.

Taking a look at the source, I can see that it's actually a plain TLS server which as far as I know is not compatible with https and explains the dropped connections. https://github.com/tableflip/guvnor/blob/v3.5.17/lib/daemon/rpc/RemoteRPC.js#L98

I personally would love it if the RPC interface was switched to https so that guvnor could stay behind nginx as the one open port and have multiple domains running other things on the same https port.

I realize that this would be a chunk of development but I think it's a feature that many would like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant