Upgrade I18n to 1.7.1 #2152
Merged
Upgrade I18n to 1.7.1 #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change in I18n ruby-i18n/i18n#503 breaks our lookup for one/many when there is also a nested hash. `Account.model_name.human` was returning the hash `{:one=>"Payment Source", :other=>"Payment Sources", :owner=>"Owner", :statuses=>{:active=>"Active", :suspended=>"Suspended"}}`. Cleaning this up seemed simpler than trying to dig in to I18n.
arnamak
approved these changes
Jan 9, 2020
|
Looks like this issue was found and possibly fixed upstream. ruby-i18n/i18n#510 I still think the cleanup is good; I'm not sure those locales should be nested under |
jhanggi
added a commit
that referenced
this pull request
Jan 22, 2020
# Release Notes "Manage Journals" got reverted to "Manage Journal". Add the "s" back on. # Additional Context Looks like it was broken by #2152 because we didn't have a journal translation/pluralization in the locales. It was using `model.human_name.pluralize` before; now it's using `model.human_name(count: :many)`.
joshea0
pushed a commit
to SquaredLabs/nucore-uconn
that referenced
this pull request
Mar 18, 2020
This change in I18n ruby-i18n/i18n#503 breaks our lookup for one/many when there is also a nested hash. `Account.model_name.human` was returning the hash `{:one=>"Payment Source", :other=>"Payment Sources", :owner=>"Owner", :statuses=>{:active=>"Active", :suspended=>"Suspended"}}`. Cleaning this up seemed simpler than trying to dig in to I18n.
joshea0
pushed a commit
to SquaredLabs/nucore-uconn
that referenced
this pull request
Mar 18, 2020
# Release Notes "Manage Journals" got reverted to "Manage Journal". Add the "s" back on. # Additional Context Looks like it was broken by tablexi#2152 because we didn't have a journal translation/pluralization in the locales. It was using `model.human_name.pluralize` before; now it's using `model.human_name(count: :many)`.
chrixp
pushed a commit
to SquaredLabs/nucore-uconn
that referenced
this pull request
Oct 21, 2020
This change in I18n ruby-i18n/i18n#503 breaks our lookup for one/many when there is also a nested hash. `Account.model_name.human` was returning the hash `{:one=>"Payment Source", :other=>"Payment Sources", :owner=>"Owner", :statuses=>{:active=>"Active", :suspended=>"Suspended"}}`. Cleaning this up seemed simpler than trying to dig in to I18n.
chrixp
pushed a commit
to SquaredLabs/nucore-uconn
that referenced
this pull request
Oct 21, 2020
# Release Notes "Manage Journals" got reverted to "Manage Journal". Add the "s" back on. # Additional Context Looks like it was broken by tablexi#2152 because we didn't have a journal translation/pluralization in the locales. It was using `model.human_name.pluralize` before; now it's using `model.human_name(count: :many)`.
joshea0
pushed a commit
to SquaredLabs/nucore-uconn
that referenced
this pull request
Oct 23, 2020
This change in I18n ruby-i18n/i18n#503 breaks our lookup for one/many when there is also a nested hash. `Account.model_name.human` was returning the hash `{:one=>"Payment Source", :other=>"Payment Sources", :owner=>"Owner", :statuses=>{:active=>"Active", :suspended=>"Suspended"}}`. Cleaning this up seemed simpler than trying to dig in to I18n.
joshea0
pushed a commit
to SquaredLabs/nucore-uconn
that referenced
this pull request
Oct 23, 2020
# Release Notes "Manage Journals" got reverted to "Manage Journal". Add the "s" back on. # Additional Context Looks like it was broken by tablexi#2152 because we didn't have a journal translation/pluralization in the locales. It was using `model.human_name.pluralize` before; now it's using `model.human_name(count: :many)`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Tech task: Bump I18n gem to 1.7.1.
Additional Context
This change in I18n ruby-i18n/i18n#503 breaks our lookup for one/many when there is also a nested hash.
Account.model_name.humanwas returning the hash{:one=>"Payment Source", :other=>"Payment Sources", :owner=>"Owner", :statuses=>{:active=>"Active", :suspended=>"Suspended"}}.Cleaning this up seemed simpler than trying to dig in to I18n.