Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cancancan from 3.1.0 to 3.6.1 #4284

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 28, 2024

Bumps cancancan from 3.1.0 to 3.6.1.

Release notes

Sourced from cancancan's releases.

3.5.0

See CHANGELOG for details

3.4.0

See CHANGELOG for details.

3.3.0

See CHANGELOG for details.

3.2.0

https://dev.to/coorasse/cancancan-3-2-0-23cj

Changelog

Sourced from cancancan's changelog.

3.6.0

3.5.0

3.4.0

  • #691: Add two new subquery strategies: joined_alias_exists_subquery, joined_alias_each_rule_as_exists_subquery. ([@​kaspernj][])
  • #767: Improve ability checks with nested resources (hash checks)vim. ([@​Juleffel][])
  • #772: Support non-hash conditions in ability definitions. ([@​Juleffel][])
  • #773: Drop support for ruby 2.4 and 2.5. ([@​coorasse][])
  • #778: Drop support for ActiveRecord 4. ([@​coorasse][])

3.3.0

3.2.2

3.2.1

3.2.0

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels May 28, 2024
@dependabot dependabot bot requested a review from a team May 28, 2024 04:31
Bumps [cancancan](https://github.com/CanCanCommunity/cancancan) from 3.1.0 to 3.6.1.
- [Release notes](https://github.com/CanCanCommunity/cancancan/releases)
- [Changelog](https://github.com/CanCanCommunity/cancancan/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/CanCanCommunity/cancancan/commits)

---
updated-dependencies:
- dependency-name: cancancan
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/cancancan-3.6.1 branch from 22b5af6 to 399583c Compare June 26, 2024 23:19
@joaquinco
Copy link
Collaborator

Failing tests are related to a behaviour change on how STI are handled.

We have something like the following in our ability which is not handled as expected:

can [:update, :show, ...], Reservation
cannot :manage, OfflineReservation

where OfflineReservation inherits from Reservation.

Related issues:

Posible solutions:

  • monkey patch cancancan
  • stay on v3.1.0

@LeticiaErrandonea
Copy link
Collaborator

@joaquinco could disabling the rules compressor for that solve this issue (see CanCanCommunity/cancancan#798)?

@joaquinco
Copy link
Collaborator

@LeticiaErrandonea I tried disabling the rule compresor but didn't fix our issues

@joaquinco
Copy link
Collaborator

Created task #162441 to follow up this gem update

@joaquinco joaquinco closed this Oct 15, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 15, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/bundler/cancancan-3.6.1 branch October 15, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code Tech task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants