Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle navigation Button Bug #51

Open
sunanan opened this issue Apr 15, 2016 · 1 comment
Open

Toggle navigation Button Bug #51

sunanan opened this issue Apr 15, 2016 · 1 comment

Comments

@sunanan
Copy link

sunanan commented Apr 15, 2016

I just try your Bootstrap 3 demo
https://tagawa.github.io/bootstrap-without-jquery/bootstrap3/demo/

when I change the window size to small, I will the see the Toggle navigation Button. that's normal.
now, I hit the button many times quickly. the button will be frozen.

so if I refresh the page, and click the button slowly, one by one. the button is working fine.
I use your Js in my project. my daughter find the problem. you know, the kids always like click sound.

my system is windows 7 with chrome
toggle navigation button

@sunanan
Copy link
Author

sunanan commented Apr 15, 2016

Got it. find the bug in doCollapse function.
before:

if (dataTarget.classList.contains('in')) {
hide(dataTarget, targets.evTarget);
} else {
show(dataTarget, targets.evTarget);
}

after

if (!dataTarget.classList.contains('collapsing')) {
if (dataTarget.classList.contains('in')) {
hide(dataTarget, targets.evTarget);
} else {
show(dataTarget, targets.evTarget);
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant