Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--test-threads override doesn't work #261

Closed
def- opened this issue Apr 21, 2023 · 4 comments
Closed

--test-threads override doesn't work #261

def- opened this issue Apr 21, 2023 · 4 comments
Labels
A-nextest Area: nextest integration https://github.com/nextest-rs/nextest

Comments

@def-
Copy link
Contributor

def- commented Apr 21, 2023

The README states:

All the tests are run with RUST_TEST_THREADS=1 to work around [https://github.com/rust-lang/rust/issues/91092]. You can pass --test-threads (e.g., --test-threads=$(nproc)) to override this behavior. (As for nextest, we also set NEXTEST_TEST_THREADS=1.)

But in nextest --test-threads seems to be ignored when NEXTEST_TEST_THREADS=1 is set. Could cargo-llvm-cov detect --test-threads being set and not set NEXTEST_TEST_THREADS=1 then?

@taiki-e
Copy link
Owner

taiki-e commented Apr 21, 2023

Please tell us what the full command you used is.

@taiki-e taiki-e added the A-nextest Area: nextest integration https://github.com/nextest-rs/nextest label Apr 21, 2023
@def-
Copy link
Contributor Author

def- commented Apr 21, 2023

cargo llvm-cov nextest --test-threads=16 --no-clean --no-fail-fast
I'm still seeing only one test being executed at a time, runs for about an hour.
Edit: Actually, towards the end the number of tests running is going up, but stays around 1-2 during the start, strange.

@def-
Copy link
Contributor Author

def- commented Apr 21, 2023

This appears to be a problem on my side, sorry.

@def- def- closed this as completed Apr 21, 2023
@taiki-e
Copy link
Owner

taiki-e commented Jun 2, 2023

FYI, since cargo-llvm-cov 0.5.20, we no longer set RUST_TEST_THREADS/NEXTEST_TEST_THREADS and now adopt a more efficient alternative to workaround rustc bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-nextest Area: nextest integration https://github.com/nextest-rs/nextest
Projects
None yet
Development

No branches or pull requests

2 participants