feat: implement release-please workflow #12967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #12967 +/- ##
=======================================
Coverage 66.39% 66.39%
=======================================
Files 113 113
Lines 3050 3050
Branches 357 357
=======================================
Hits 2025 2025
Misses 949 949
Partials 76 76
*This pull request uses carry forward flags. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
davidtaikocha
previously approved these changes
Jan 18, 2023
dantaik
reviewed
Jan 18, 2023
dantaik
approved these changes
Jan 18, 2023
davidtaikocha
approved these changes
Jan 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary of changes
This PR will implement release-please. git-cliff was not good enough for publishing release-notes, and changesets added unnecessary complexity imo by requiring devs to add a changeset -- this solution will work with our conventional commits standard. I tested it out on my taiko-mono fork, and it works awesome.
I am giving every package, including the root, a
package.jsonto declare the version. As we make conventional commits throughout our work iteration, the github-action will update a release PR.We can merge this release PR at a cadence, and it will bump / release packages for those that have changes in the git diff that matches that sub-package path. It will push some tags:
<packageName>-vx.y.zfor each each sub-package release as well.