Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(relayer): Eth bridge #14609

Merged
merged 6 commits into from
Aug 30, 2023
Merged

fix(relayer): Eth bridge #14609

merged 6 commits into from
Aug 30, 2023

Conversation

cyberhorsey
Copy link
Contributor

with refactors to relayer to accomodate for NFTs, eth claiming had a bug where it was assumed we would always have a canonical token.

@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
bridge-ui-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2023 6:02pm

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #14609 (42ff6bd) into main (87c9d53) will decrease coverage by 0.15%.
Report is 8 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #14609      +/-   ##
==========================================
- Coverage   65.18%   65.04%   -0.15%     
==========================================
  Files          87       87              
  Lines        3111     3115       +4     
  Branches      109      109              
==========================================
- Hits         2028     2026       -2     
- Misses        959      965       +6     
  Partials      124      124              
Flag Coverage Δ *Carryforward flag
bridge-ui 93.91% <ø> (ø) Carriedforward from 87c9d53
eventindexer 45.60% <ø> (ø) Carriedforward from 87c9d53
relayer 57.21% <0.00%> (-0.26%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
packages/relayer/indexer/handle_event.go 38.46% <0.00%> (-2.08%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cyberhorsey cyberhorsey added this pull request to the merge queue Aug 30, 2023
Merged via the queue into main with commit f5207ae Aug 30, 2023
9 checks passed
@cyberhorsey cyberhorsey deleted the eth_bridge branch August 30, 2023 20:01
@github-actions github-actions bot mentioned this pull request Aug 30, 2023
2manslkh pushed a commit that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants