Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(taiko-client): only invalid status need to return error #17266

Merged
merged 3 commits into from
May 20, 2024

Conversation

mask-pp
Copy link
Contributor

@mask-pp mask-pp commented May 20, 2024

No description provided.

@mask-pp mask-pp marked this pull request as draft May 20, 2024 09:58
@mask-pp mask-pp linked an issue May 20, 2024 that may be closed by this pull request
1 task
@mask-pp mask-pp marked this pull request as ready for review May 20, 2024 11:09
@davidtaikocha
Copy link
Member

Lets add at least one more unit test for this case.

@davidtaikocha davidtaikocha added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit e7111e0 May 20, 2024
3 checks passed
@davidtaikocha davidtaikocha deleted the handle_invalid_status branch May 20, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Prover transaction without error on prover client
3 participants