Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(docs-site): added documentation for PORTERS #18033

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

scermat
Copy link
Contributor

@scermat scermat commented Sep 4, 2024

Added documentation with reference to the PORTERS service and the Taiko Name Service API provided by PORTERS.

This was done in line with the ask requested from @benedictvscriticus.

Sections Updated

  • Resources / Developer Tools: Added card with a link to PORTERS
  • Resources: Added node providers page with a high level overview of what PORTERS provides in relation to Taiko.

Copy link

vercel bot commented Sep 4, 2024

@scermat is attempting to deploy a commit to the taikoxyz Team on Vercel.

A member of the Team first needs to authorize it.

@scermat scermat changed the title docs(docs-site): Added documentation for PORTERS docs(docs-site): added documentation for PORTERS Sep 4, 2024
@RogerLamTd
Copy link
Contributor

@scermat I believe this may belong in our ecosystem page, not our documentation. Please feel free to open a issue here

@RogerLamTd RogerLamTd closed this Sep 4, 2024
@benedictvscriticus
Copy link

Hi @RogerLamTd! Thank you for your feedback, however @swarna1101 specifically requested us to add this to your documentation. Please clarify this matter internally and inform us over our established channels with the Taiko team where you would like us to add this.

If you prefer to sort this out outside of a PR, we are also happy to provide you with the necessary information for you to add this wherever you see fit.

Thank you for your understanding.

@RogerLamTd
Copy link
Contributor

Hi @RogerLamTd! Thank you for your feedback, however @swarna1101 specifically requested us to add this to your documentation. Please clarify this matter internally and inform us over our established channels with the Taiko team where you would like us to add this.

If you prefer to sort this out outside of a PR, we are also happy to provide you with the necessary information for you to add this wherever you see fit.

Thank you for your understanding.

Ah I wasn't aware! Let me confirm and get back to you.

@benedictvscriticus
Copy link

Hi @RogerLamTd! Thank you for your feedback, however @swarna1101 specifically requested us to add this to your documentation. Please clarify this matter internally and inform us over our established channels with the Taiko team where you would like us to add this.
If you prefer to sort this out outside of a PR, we are also happy to provide you with the necessary information for you to add this wherever you see fit.
Thank you for your understanding.

Ah I wasn't aware! Let me confirm and get back to you.

No worries, just let us know and we'll take it from there.

@RogerLamTd RogerLamTd reopened this Sep 5, 2024
@RogerLamTd
Copy link
Contributor

@benedictvscriticus Checked with @swarna1101, we can add to docs!

Copy link
Contributor Author

@scermat scermat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side happy for you to proceed internally, feel free to apply any tweaks you deem appropriate to fit within the wider Taiko docs

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
taiko-mono ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 0:33am

@RogerLamTd RogerLamTd added this pull request to the merge queue Sep 12, 2024
Merged via the queue into taikoxyz:main with commit 548884d Sep 12, 2024
7 checks passed
Copy link

gitpoap-bot bot commented Sep 12, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Taiko Contributor:

GitPOAP: 2024 Taiko Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants