Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(taiko-client): allow --l1.beacon to be optional when a blob server is given #18094

Merged
merged 7 commits into from
Sep 15, 2024

Conversation

mask-pp
Copy link
Contributor

@mask-pp mask-pp commented Sep 14, 2024

During hive test, I found that l1.beacon should be optional otherwise driver can never call BLOB_SOCIAL_SCAN_ENDPOINT and BLOB_SERVER in common situation.

@mask-pp mask-pp changed the title feat(taiko-client): let l1.beacon be optional feat(taiko-client): let l1.beacon be optional and at least one blob client is not empty Sep 15, 2024
@davidtaikocha davidtaikocha changed the title feat(taiko-client): let l1.beacon be optional and at least one blob client is not empty feat(taiko-client): allow --l1.beacon to be optional when a blob server is given Sep 15, 2024
@davidtaikocha davidtaikocha added this pull request to the merge queue Sep 15, 2024
Merged via the queue into main with commit f4d47a3 Sep 15, 2024
7 checks passed
@davidtaikocha davidtaikocha deleted the driver_optional_l1_beacon_ branch September 15, 2024 12:24
dantaik pushed a commit that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants