Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bridge): bridge design #369

Merged
merged 33 commits into from
Dec 6, 2022
Merged

feat(bridge): bridge design #369

merged 33 commits into from
Dec 6, 2022

Conversation

shadab-taiko
Copy link
Contributor

No description provided.

@shadab-taiko shadab-taiko marked this pull request as draft November 30, 2022 15:28
packages/bridge-ui/src/domain/fee.ts Outdated Show resolved Hide resolved
packages/bridge-ui/src/store/fee.ts Outdated Show resolved Hide resolved
packages/bridge-ui/src/store/fee.ts Outdated Show resolved Hide resolved
packages/bridge-ui/src/utils/addressAvatar.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #369 (72864f3) into main (a546ee9) will increase coverage by 1.59%.
The diff coverage is 100.00%.

❗ Current head 72864f3 differs from pull request most recent head b81108f. Consider uploading reports for the commit b81108f to get more accurate results

@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
+ Coverage   64.38%   65.97%   +1.59%     
==========================================
  Files          90       94       +4     
  Lines        2524     2519       -5     
  Branches      292      291       -1     
==========================================
+ Hits         1625     1662      +37     
+ Misses        827      784      -43     
- Partials       72       73       +1     
Flag Coverage Δ *Carryforward flag
bridge-ui 100.00% <100.00%> (ø)
protocol 60.90% <ø> (+1.89%) ⬆️ Carriedforward from 90a7595
relayer 68.92% <ø> (ø) Carriedforward from 90a7595
ui 100.00% <100.00%> (ø) Carriedforward from 90a7595

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/bridge-ui/src/domain/chain.ts 100.00% <100.00%> (ø)
packages/bridge-ui/src/relayer/service.ts 100.00% <100.00%> (ø)
packages/bridge-ui/src/utils/addressAvatar.ts 100.00% <100.00%> (ø)
packages/bridge-ui/src/utils/addressSubsection.ts 100.00% <100.00%> (ø)
...ackages/bridge-ui/src/utils/switchEthereumChain.ts 100.00% <100.00%> (ø)
packages/bridge-ui/src/utils/truncateString.ts 100.00% <100.00%> (ø)
packages/protocol/contracts/L1/LibData.sol 21.42% <0.00%> (ø)
packages/protocol/contracts/L1/TkoToken.sol 84.21% <0.00%> (ø)
packages/protocol/contracts/L2/V1TaikoL2.sol 56.81% <0.00%> (ø)
... and 18 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cyberhorsey cyberhorsey marked this pull request as ready for review December 1, 2022 18:32
cyberhorsey
cyberhorsey previously approved these changes Dec 1, 2022
cyberhorsey and others added 4 commits December 2, 2022 08:29
* feat(bridge-ui): ERC20 Bridge + approval (#353)

* erc20 bridge + approve + requires allowance

* bridge form checks allowance, disables button

* if allowance is required, show approve button instead

* set allowance required to false after successful approval

* requiresallowance should take approveopts, not bridgeopts

* show Approve text appropriatley

* Update packages/bridge-ui/src/components/form/BridgeForm.svelte

Co-authored-by: David <[email protected]>

* Update packages/bridge-ui/src/eth/bridge.ts

Co-authored-by: David <[email protected]>

* Update packages/bridge-ui/src/components/form/BridgeForm.svelte

Co-authored-by: David <[email protected]>

* Update packages/bridge-ui/src/components/form/BridgeForm.svelte

Co-authored-by: David <[email protected]>

* inverse approve logic

Co-authored-by: David <[email protected]>

* .

* lottie player

* update lockfile

Co-authored-by: David <[email protected]>
RogerLamTd
RogerLamTd previously approved these changes Dec 5, 2022
@vercel
Copy link

vercel bot commented Dec 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
bridge-ui ✅ Ready (Inspect) Visit Preview Dec 6, 2022 at 5:30PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
website ⬜️ Ignored (Inspect) Dec 6, 2022 at 5:30PM (UTC)

@cyberhorsey cyberhorsey enabled auto-merge (squash) December 6, 2022 17:35
@cyberhorsey cyberhorsey merged commit 04702db into main Dec 6, 2022
@cyberhorsey cyberhorsey deleted the bridge-design branch December 6, 2022 17:36
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants