Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolls to top on #hash change #10

Closed
zackify opened this issue May 11, 2016 · 4 comments
Closed

Scrolls to top on #hash change #10

zackify opened this issue May 11, 2016 · 4 comments

Comments

@zackify
Copy link

zackify commented May 11, 2016

Take out the plugin, link to an id on the page, it works. Add this back, it will scroll up instead of to the id. I'll look into it myself but I wanted to post this so it's known first.

@taion
Copy link
Owner

taion commented May 11, 2016

Just return false from shouldUpdateScroll if only hash changes. Note per taion/scroll-behavior#22 that there's no handling for navigating to a different route with a hash.

@taion taion closed this as completed May 11, 2016
@zackify
Copy link
Author

zackify commented May 11, 2016

Okay got it.

@f0rr0
Copy link

f0rr0 commented Sep 26, 2016

@taion How would the back button work for same page hash anchors in that case?

@taion
Copy link
Owner

taion commented Sep 26, 2016

It wouldn't, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants