Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handleOutsideMouseClick is invoked twice when testing mobile interfaces in Chrome #134

Closed
matthewgertner opened this issue Feb 20, 2017 · 1 comment
Closed

handleOutsideMouseClick is invoked twice when testing mobile interfaces in Chrome #134

matthewgertner opened this issue Feb 20, 2017 · 1 comment
Labels
bug

Comments

@matthewgertner
Copy link

I'm testing my Cordova app in Chrome. I guess when you set dev tools to simulate taps, both mouseup and touchstart are triggered when you click outside the portal. As a result, handleOutsideMouseClick is invoked twice. Maybe it would make sense to remove the event listeners in handkeOutsideMouseClick so it can only ever be invoked once?
@tajo tajo added the bug label Jul 29, 2017
@tajo
Copy link
Owner

tajo commented Oct 1, 2017

Hey, please check the new major version of react-portal: #157

It's React v16 only since its uses the new official Portal API. There is the first beta released and I would like to get your feedback. I don't have bandwidth to maintain v3 which is very different and full of hacks.

I am happy to discuss this with v4 in mind. If this is still a problem, please re-open/update the issue. Thanks.

@tajo tajo closed this as completed Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matthewgertner @tajo