Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thoughts on passing event object from handleWrapperClick to openPortal? #139

Closed
noah-potter opened this issue Mar 17, 2017 · 2 comments
Closed

Thoughts on passing event object from handleWrapperClick to openPortal? #139

noah-potter opened this issue Mar 17, 2017 · 2 comments
Labels
question

Comments

@noah-potter
Copy link

Is there a particular reason handleWrapperClick doesn't pass the event object when it calls openPortal? I'm trying to use the mouse position in props.onOpen

I'll submit a PR if this is wanted.
@tajo
Copy link
Owner

tajo commented Jul 29, 2017

Let's revisit this later. I'm doing a big rewrite with v4.

@tajo
Copy link
Owner

tajo commented Oct 1, 2017

Hey, please check the new major version of react-portal: #157

It's React v16 only since its uses the new official Portal API. There is the first beta released and I would like to get your feedback. I don't have bandwidth to maintain v3 which is very different and full of hacks.

I am happy to discuss this with v4 in mind. If this is still a problem, please re-open/update the issue. Thanks.

@tajo tajo closed this as completed Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tajo @noah-potter