Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React peerDependency #151

Closed
Matt-Butler opened this issue May 17, 2017 · 1 comment
Closed

React peerDependency #151

Matt-Butler opened this issue May 17, 2017 · 1 comment
Labels
enhancement
Milestone
v4

Comments

@Matt-Butler
Copy link

Matt-Butler commented May 17, 2017 •
edited
Loading

React and react-dom are both imported in your code. Should react and react-dom be added as a peerDependency? An application would not be able to use this library unless react as been installed.

https://github.com/tajo/react-portal/blob/master/lib/portal.js#L1-L2
@tajo tajo added this to the v4 milestone Jul 29, 2017
@tajo
Copy link
Owner

tajo commented Oct 1, 2017

Done in #157

@tajo tajo closed this as completed Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v4
Development

No branches or pull requests
2 participants
@tajo @Matt-Butler