Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plans re: React v16 #163

Closed
macgyver opened this issue Sep 27, 2017 · 3 comments
Closed

plans re: React v16 #163

macgyver opened this issue Sep 27, 2017 · 3 comments

Comments

@macgyver
Copy link

This is a great project that has shaped and informed the development of the ecosystem, which is evidenced by convergent evolution for other frameworks, e.g. https://github.com/LinusBorg/portal-vue and https://github.com/yapplabs/ember-wormhole, and now with the introduction of portals as a core feature in React v16.

Just curious, what is the future of the react-portal package?

@tajo
Copy link
Owner

tajo commented Sep 27, 2017

So my plan is to significantly simplify this library (there is already some code in master). Having only basic minimalistic wrapper for createPortal that will handle server side rendering and by default appends portal into document.body (with an option to specify your own node). I think that's still quite useful and covers 90% of use-cases.

I am still not sure if it's valuable to keep/develop stateful version of portal. It's nice for some basic use-cases but people tend to overuse it, asking for various life-cycle hooks while they should be rather using stateless version and implement whatever they need around it.

Opinions welcome!

@tajo
Copy link
Owner

tajo commented Sep 27, 2017

Obviously this library is pretty popular (over 300k downloads/month) so I don't want to cause a crisis but some major changes are needed.

@tajo
Copy link
Owner

tajo commented Oct 1, 2017

Check: #157

@tajo tajo closed this as completed Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants