Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect onClick prop on openByClickOn element. #97

Closed
Andreyco opened this issue Sep 14, 2016 · 2 comments
Closed

Respect onClick prop on openByClickOn element. #97

Andreyco opened this issue Sep 14, 2016 · 2 comments
Labels
enhancement

Comments

@Andreyco
Copy link

Trigger element passed via openByClickOn is cloned and receives Portal's very own onClick handler. Is it acceptable to invoke it's original onClick handler as well?

Got working fork, will create PR if proposal accepted.
@woodenconsulting woodenconsulting mentioned this issue Oct 5, 2016
Closed
@tajo
Copy link
Owner

tajo commented Dec 29, 2016

This #120 ?

@tajo
Copy link
Owner

tajo commented Oct 1, 2017

Hey, please check the new major version of react-portal: #157

It's React v16 only since its uses the new official Portal API. There is the first beta released and I would like to get your feedback. I don't have bandwidth to maintain v3 which is very different and full of hacks.

I am happy to discuss this with v4 in mind. If this is still a problem, please re-open/update the issue. Thanks.

@tajo tajo closed this as completed Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Andreyco @tajo